https://kotlinlang.org logo
Title
j

jlleitschuh

09/18/2017, 4:32 PM
@bamboo You have any more thoughts on the JDK 9 PR re: why travis might be failing?
b

bamboo

09/18/2017, 10:39 PM
I will take a good look Tomorrow.
Hey @jlleitschuh, the travis build is looking really good actually, the only failure under JDK 9 was in
GradleKotlinDslIntegrationTest > given a plugin compiled against Kotlin one dot zero, it will run against the embedded Kotlin version
and that’s because publishing the plugin used by test has been explicitly disabled
I’d say the only thing missing now is disabling that test when running under JDK9
If you think that’s something better done with JUnit 5, please go ahead
j

jlleitschuh

09/19/2017, 2:47 PM
Actually, using Junit 4 you can simply use
assume
which will skip the test if the assumption fails. https://github.com/junit-team/junit4/wiki/Assumptions-with-assume
@bamboo Looks like we got a successful build!!!! 😄 https://github.com/gradle/kotlin-dsl/pull/455 EDIT: I need to change the code, but this is the success: https://travis-ci.org/gradle/kotlin-dsl/builds/277344475
b

bamboo

09/19/2017, 4:50 PM
\o/
Very nice, @jlleitschuh!
j

jlleitschuh

09/19/2017, 5:48 PM
Fixed up after your feedback.
b

bamboo

09/19/2017, 5:49 PM
Great, will merge in a moment.
j

jlleitschuh

09/19/2017, 5:49 PM
Thanks!!! 😄
b

bamboo

09/19/2017, 5:49 PM
Thank you! 🙂
j

jlleitschuh

09/19/2017, 5:49 PM
This fix should be in Gradle 4.x something?
b

bamboo

09/19/2017, 5:57 PM
Gradle 4.3 for sure
Merged
j

jlleitschuh

09/19/2017, 5:59 PM
🎉 Woot! 🎉