<@U0QBCLV62> You have any more thoughts on the JDK 9 PR re: why travis might be failing?

# gradle

[jlleitschuh]

@bamboo You have any more thoughts on the JDK 9 PR re: why travis might be failing?

[bamboo]

I will take a good look Tomorrow.

[bamboo]

Hey @jlleitschuh, the travis build is looking really good actually, the only failure under JDK 9 was in GradleKotlinDslIntegrationTest > given a plugin compiled against Kotlin one dot zero, it will run against the embedded Kotlin version and that’s because publishing the plugin used by test has been explicitly disabled

[bamboo]

I’d say the only thing missing now is disabling that test when running under JDK9

[bamboo]

If you think that’s something better done with JUnit 5, please go ahead

[jlleitschuh]

Actually, using Junit 4 you can simply use assume which will skip the test if the assumption fails.

https://github.com/junit-team/junit4/wiki/Assumptions-with-assume

[bamboo]

\o/

[bamboo]

Very nice, @jlleitschuh!

[jlleitschuh]

Fixed up after your feedback.

[bamboo]

Great, will merge in a moment.

[jlleitschuh]

Thanks!!! 😄

[bamboo]

Thank you! 🙂

[jlleitschuh]

This fix should be in Gradle 4.x something?

[bamboo]

Gradle 4.3 for sure

[bamboo]

Merged

[jlleitschuh]

🎉 Woot! 🎉