If I have some best-effort code, I might write it as ```try { foo() } catch (ex: Exception) { ...

# coroutines

[Aidan Low]

If I have some best-effort code, I might write it as

try {
   foo()
} catch (ex: Exception) {
   // ignore failures, best effort
}

but if I'm inside a coroutine, will this screw up cooperative cancellation? Do I need to do something like

try {
  foo()
} catch (ex: CancellationException) {
  throw ex
} catch (ex: Exception) {
  // ignore failures, best effort
}

?

[Tijl]

yes, you do

[Aidan Low]

I was afraid of that. Thanks. 🙂

[ephemient]

that also screws up Java thread interruption

[Aidan Low]

that also screws up Java thread interruption

Will that be handled by re-throwing CancellationException as in my second block of code?

[Aidan Low]

Or are there additional changes required for the Java thread case?

[ephemient]

Java uses a different InterruptedException

[ephemient]

in general catching and failing to rethrow exceptions is a bad idea. only handle exceptions you know you can handle

[Aidan Low]

Yeah, I'm not super happy about it either. (massive legacy codebase 🥳 )