Hey guys, i have the following snippet and would r...

# coroutines

[Nikiizvorski]

Hey guys, i have the following snippet and would really appreciate some help. So basically this function is being called from another coroutine but this one is blocking even after everything else returns and it’s done so it’s like it never finish. Do you guys see something wrong with it? When i comment it out everything else works fine. override suspend fun waitForFix(timeoutMsec: Long, scope: CoroutineScope): Location? {
return getLocation() ?: let {
val channel = Channel<Location?>(1)
val timeout = scope.launch {
delay(timeoutMsec)
channel.send(null)
}
getUpdates { fix ->
scope.launch {
timeout.cancel()
channel.send(fix)
}
}

channel.receive()
}
}

[Oliver.O]

Probably getUpdates() is blocking and does not support cancellation. If it were cancellable, you might want to use withTimeout { ... } instead of your channel-based solution. See https://stackoverflow.com/a/47641886/2529022

[Nikiizvorski]

I was thinking about that thanks i will look into it. Usually that’s just a location fetch. But i will try to replace it withTimeout should be better.

[Nikiizvorski]

So i was thinking how it would if i change them to trySend and tryReceive it should be good then right

[Nikiizvorski]

I have ended up with this solution which seem’s to work quite fine for me. Tested it and seem’s not to block anymore.

[Nikiizvorski]

withTimeout(timeoutMsec) {
    getUpdates { fix ->
        scope.launch {
            channel.trySend(fix)
        }
    }
    channel.receive()
}

[Oliver.O]

As trySend() is non-blocking, you can avoid the overhead of an extra coroutine:

getUpdates { channel.trySend(it) }

should do just fine.

[Nikiizvorski]

Yes you are right. Was a bit tired didn't even see it. 😴 Thank you Oliver!