answer is not exactly It all works with the assumption that

Question

answer is not exactly It all works with the assumption that the underlying executor will throw if shutdown I was looking at bad code that s wrapping an android handler and not throwing if the task is rejected hence blocking forever

louiscad · Answer

You can do use `asCoroutineDispatcher ` on a `Handler` instance it s part of kotlinx coroutines android I think the implementation it provides is correct for this edge case

py · Answer

Thx for the pointer Actually the official Handler asCoroutineDispatcher is broken as well and will cause runBlocking to block forever if the HandlerThread has already quit when dispatching <https cs android com android platform superproject + master external kotlinx coroutines ui kotlinx coroutines android src HandlerDispatcher kt l=132 drc=79e555e45bb928b98f5944a1dc67bf02d5117ea5|https cs android com android platform superproject + master external kotlinx coroutines ui kotlinx coroutines android src HandlerDispatcher kt l=132 drc=79e555e45bb928b98f5944a1dc67bf02d5117ea5>

louiscad · Answer

And here s the canonical permalink on GitHub <https github com Kotlin kotlinx coroutines blob b852b20131fff5c0d605d7cb5f8001b715f02c1e ui kotlinx coroutines android src HandlerDispatcher kt L131|https github com Kotlin kotlinx coroutines blob b852b20131fff5c0d605d7cb5f8001b715f02c1e ui kotlinx coroutines android src HandlerDispatcher kt L131> Do you want to send the PR or should I do it

Zach Klippenstein (he/him) [MOD] · Answer

What s the fix for `asCoroutineDispatcher` I didn t think the `dispatch` method was allowed to throw so the execution rejected exception approach wouldn t work

py · Answer

Great question Executor asCoroutineDispatcher catches rejection and delegates the work to

py · Answer

gt If the underlying executor throws on attempt to submit a continuation task it happens when the resulting dispatcher on underlying executor or when it uses limited queues then the of the affected task is and the task is submitted to the so that the affected coroutine can cleanup its resources and promptly complete

py · Answer

gt Do you want to send the PR or should I do it < louiscad> you re welcome to This might be quite involved look at the Executors impl maybe worth filing an issue

py · Answer