https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
m

Michal Klimczak

02/23/2021, 7:12 PM
Can multiple different threads 'join' the same Job? I have a library which expects blocking calls to some 'authenticate' method. This method will then be called from multiple threads and invoke a 'refreshToken' suspend function (which has to be invoked in runBlocking because 'authenticate' is expected to be blocking) but if some of these calls are called simultaneously I only want the 'refreshToken' to be called once for all of of them. My idea is to create a Job when the first one hits and them all the other could join this Job if it still exists. Is it a good approach or is there a better way?
(Sorry, writing this from my mobile)
z

Zach Klippenstein (he/him) [MOD]

02/23/2021, 7:13 PM
Yep, any coroutine can call
join()
on any
Job
instance (whether or not those coroutines are running on different threads)
❤️ 1
m

Michal Klimczak

02/23/2021, 7:24 PM
And runBlocking is still an "any coroutine" right?
w

wasyl

02/23/2021, 7:27 PM
Yes 🙂
☝️ 1
❤️ 1
m

Michal Klimczak

02/23/2021, 7:30 PM
Thank you guys!
u

uli

02/23/2021, 8:44 PM
Just make sure your detection, wether a refresh is already running is not racey.
m

Michal Klimczak

02/23/2021, 9:04 PM
I've prepared something like this
/**
 * If it doesn't run, it is started.
 * If it runs, multiple observers might suspend waiting for the result.
 */
class ConnectableCoroutine<T>(
    private val scope: CoroutineScope,
    private val block: suspend () -> T
) {

    private var deferred: Deferred<T>? = null

    suspend fun connect(): T {
        println("CC: Started with deferred: $deferred at ${Thread.currentThread()}")
        if (deferred == null || deferred!!.isCompleted) {
            deferred = scope.async {
                println("CC: Perform at ${Thread.currentThread()}")
                block()
            }
        }
        deferred!!.join()
        return deferred!!.await()
    }

}
And it runs fine when used the "regular" way, i.e. in suspended functions. But it seems to be messed up when used in non-coroutine contexts with`runBlocking` . Or my rough test might be totally wrong, but I don't really have an idea for another (I know the sleeps are bad, but right now I'm trying to simulate what okhttp does under the hood). The test that fails goes like this:
@Test
    fun test2() = runBlockingTest {

        coEvery { stringProvider.provideString() } returnsMany listOf("a", "b", "c")

        val connectableCoroutine = ConnectableCoroutine(this) {
            Thread.sleep(1000)
            stringProvider.provideString()
        }

        lateinit var result1: String
        lateinit var result2: String
        lateinit var result3: String

        thread(name = "thread1") {
            result1 = runBlocking { connectableCoroutine.connect() }
        }
        Thread.sleep(200) //let's make sure it's not a race condition
        thread(name = "thread2") {
            result2 = runBlocking { connectableCoroutine.connect() }
        }
        Thread.sleep(2000)
        thread(name = "thread3") {
            result3 = runBlocking { connectableCoroutine.connect() }
        }
        Thread.sleep(1500)

        assertEquals("a", result1)
        assertEquals("a", result2)
        assertEquals("b", result3)

    }
result2 =b
, but it should be
a
, since I connected within the duration of the first job.
hmmmm, it seems to work when I don;t use the testCoroutineScope at all, but instead go with
ConnectableCoroutine(CoroutineScope(<http://Dispatchers.IO|Dispatchers.IO>)) {
Then the job is performed on the right dispatcher (IO). When I leave the
ConnectableCoroutine(this)
, it uses the
thread1
. I guess it's
unconfined
for TestCoroutineDispatcher or sth like this?
u

uli

02/23/2021, 9:11 PM
You consistently access
deferred
concurrently from multiple threads. For example two threads might see
deferred
to be null. Then both would start a new coroutine and overwrite each other's jobs
m

Michal Klimczak

02/23/2021, 9:14 PM
I should synchronize the access right?
u

uli

02/23/2021, 9:17 PM
True, but not with Java's/Kotlin's synchronize! And why do you join at all? I would expect await to wait for completion of the job
m

Michal Klimczak

02/23/2021, 9:21 PM
not with Java's/Kotlin's synchronize
Why not? This seems to do the trick in the test.
@Synchronized suspend fun connect(): T
The whole point of this is that there is this
ConnectableCoroutine
that will be accessed by many different threads simultaneously and if one of them calls the
block()
then all of them should wait for the job to be finished instead of launching their own jobs. Is there a better way to achieve that?
(you are right that join doesn't make any difference here)
u

uli

02/23/2021, 9:26 PM
And run blocking is single threaded. Because sleep will block that thread, you have hardly any concurrency at all. That's why case 2 is only called after the first one finished
Try replacing sleep with delay
m

Michal Klimczak

02/23/2021, 9:28 PM
I have another test which looks like this
@Test
    fun test1() = runBlockingTest {

        coEvery { stringProvider.provideString() } returnsMany listOf("a", "b", "c")

        pauseDispatcher()

        val connectableCoroutine = ConnectableCoroutine(this) {
            delay(2000)
            stringProvider.provideString()
        }

        lateinit var result1: String
        lateinit var result2: String
        lateinit var result3: String

        launch {
            result1 = connectableCoroutine.connect()
        }

        advanceTimeBy(1000)
        launch {
            result2 = connectableCoroutine.connect()
        }

        advanceTimeBy(2000)
        launch {
            result3 = connectableCoroutine.connect()
        }

        advanceTimeBy(2500)

        assertEquals("a", result1)
        assertEquals("a", result2)
        assertEquals("b", result3)
    }
u

uli

02/23/2021, 9:30 PM
And ..... ?
m

Michal Klimczak

02/23/2021, 9:30 PM
and it runs without any issues
The problem is that this
ConnectableCoroutine
is used in an okhttp.Authenticator which requires the call to authenticate to be blocking. So I need to have a runBlocking call there - that's why I'm also testing with runBlocking and sleeps
u

uli

02/23/2021, 9:30 PM
Passes or fails?
m

Michal Klimczak

02/23/2021, 9:30 PM
passes
u

uli

02/23/2021, 9:31 PM
But there you can pass a dispatcher to run blocking
m

Michal Klimczak

02/23/2021, 9:32 PM
ooooooh 😄
that sounds like what I was looking for
u

uli

02/23/2021, 9:34 PM
Out better: Make your
block
suspending
m

Michal Klimczak

02/23/2021, 9:36 PM
I don't follow you - it is a suspend lambda
👍 1
u

uli

02/23/2021, 9:36 PM
And use withContext(Dispatchers.IO)
withContext(Dispatchers.IO) {Thread.sleep(2000)}
Then you can stay on your single threaded test dispatcher
But forwarding time will not work with sleep
m

Michal Klimczak

02/23/2021, 9:43 PM
I need to grab some sleep, it's been 14 hours at the keyboard now and it's getting hard to understand all of this 😄 @uli thank you so much for your help!
u

uli

02/23/2021, 9:59 PM
Welcome. Good night