https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
p

Pablo

01/12/2021, 4:17 PM
Anyone of you can explain how retrofit / room are doing the main-safety stuff? I know that if I put suspend I can avoid the
withContext(<http://Dispatchers.IO|Dispatchers.IO>)
but what if I have some mappers and some business logic? Is it safe to remove the
withContext(<http://Dispatchers.IO|Dispatchers.IO>)
?
n

Nicholas Doglio

01/12/2021, 5:05 PM
Anyone of you can explain how retrofit / room are doing the main-safety stuff?
Under the hood both Retrofit and Room are delegating to their own way of handling async calls. For Room see this article: https://medium.com/androiddevelopers/room-coroutines-422b786dc4c5 For Retrofit the
suspend
calls just delegate to the built in
Call<T>.enqueue
which uses it’s own background executor. see https://github.com/square/retrofit/blob/master/retrofit/src/main/java/retrofit2/KotlinExtensions.kt
I know that if I put suspend I can avoid the 
withContext(<http://Dispatchers.IO|Dispatchers.IO>)
 but what if I have some mappers and some business logic? Is it safe to remove the 
withContext(<http://Dispatchers.IO|Dispatchers.IO>)
 ?
If the business logic and mappers are exclusively working with Room and Retrofit calls then yes it’s fine to remove them.
l

louiscad

01/12/2021, 6:19 PM
mapping and all should be done in
Dispatchers.Default
because it can consume a bunch of CPU (as all allocation can).
p

Pablo

01/13/2021, 7:56 AM
@louiscad Even if the mapper is not that big? I mean from now I have
<http://Dispatchers.IO|Dispatchers.IO>
unnecessary I guess because retrofit has it's own stuff, but when I'm getting the DTO I'm doing some mappers and sort etc, but it's super fast, do I have to use
Dispatchers.Default
anyways?.... I thought I had to change the Dispatcher when I have some heavy task that could work the UI
@Nicholas Doglio Thanks for that answer, it helped me a lot. My mappers are like from data to domain, and then in the use-case do some sorting stuff etc, or some other things (not that heavies though)
l

louiscad

01/13/2021, 8:43 AM
@Pablo "Not that big" can have very different meanins from one person to the other, but if you go from
<http://Dispatchers.IO|Dispatchers.IO>
to
Dispatchers.Default
without going through the main thread in between, there's no actual thread switching, so it's worth doing any computation/allocation/mapping in
Dispatchers.Default
by default, an switch to
<http://Dispatchers.IO|Dispatchers.IO>
when needed.
p

Pablo

01/13/2021, 9:11 AM
@louiscad I create a CorutineScope that is actually a
MainScope()
so, once I have that I do something like
scope.launch{
//UI stuff
withContext(IO) { usecase call }
//UI stuff
}
The thing is my usecase calls my data source and datasource does a retrofit call, everything is suspend stuff, but the problem is once I have the DTO on datasource I do a mapper to convert it to domain, then in the use-case perhaps I sort or I'm doing something (not always...) For these cases do I have to change the dispatcher ? I mean I want to remove IO because I do not need it to call the retrofit call but under the hood I have more "logic" is not like get the data parsed from JSON and print it, no, I'm doing more stuff..
l

louiscad

01/13/2021, 9:12 AM
@Pablo IMO, only the strictly UI stuff should run on the main thread. You can wrap the whole everything else into
Dispatchers.Default { }
p

Pablo

01/13/2021, 9:17 AM
ok, so main thing like show dialog, show toast, and stuff like that is ok to run it on the
Dispatchers.Main
ok, but then if we have stuff like mappers/sortings/etc better on
Dispatchers.Default
I got confused because I've read that retrofit/room are main-safety so we can call them on the main thread
l

louiscad

01/13/2021, 9:18 AM
The thing is that doing a retrofit call might not be the only work that you need to do
p

Pablo

01/13/2021, 9:18 AM
But obviously, inside of that is not only the call, there's mappers and stuff.. so you recomend to me to use
Dispatchers.Default
, right instead?
l

louiscad

01/13/2021, 9:18 AM
Same for Room
If you do almost no allocation nor CPU consuming work besides getting the data from Room, retrofit or whatever that is "main-safe", maybe sticking to the main thread is fine.
p

Pablo

01/13/2021, 9:25 AM
Correct, but as I said in the comments, I do mapper sorting comparators things, that's more work, perhaps not much like doing a for loop of 1000000 elements, but it's something...
l

louiscad

01/13/2021, 9:25 AM
Yes, that's why I recommended to use
Dispatchers.Default
👍🏽 1