What do I need to do in here in terms of closing/cancellation/throwing? This is so confusing. Do I need to close the Flow? Cancel the coroutine? Anything else?

inline fun <reified T> Query.asFlow() = callbackFlow<List<T>> {
    val registration = addSnapshotListener { snapshot, error ->
        if (error != null) {
            cancel(CancellationException("Query snapshot error", error))
        }
        offer(snapshot?.toObjects(T::class.java) ?: emptyList())
    }
    awaitClose { registration.remove() }
}

use cancel for consumer telling producer to stop, use close for producer telling consumer that there will be no more (with or without an exception)

ok, thank you

These docs might need to be improved… maybe submit an issue there?

well I can't if don't know what's right

I don't think it's correct to use

cancel()

inside a

callbackFlow

.