Can I make this code better? ```templatesDao.getAll().collectIndexed { index, templates -> t...

# coroutines

[Se7eN]

Can I make this code better?

templatesDao.getAll().collectIndexed { index, templates ->

    templatesLiveData.value = templates
    if(index == 0) {
        val newTemplates = getTemplatesFromFirestore(templates.lastIndex)
        templatesDao.insert(newTemplates)
    }
}

Is there any function like flow.onFirst { } or something like that

[ansman]

You can implement your own extension for this but otherwise I would say this is fine.

[travis]

Assuming the DAO is providing a sharable Flow, then I tend to prefer avoiding side-effects in operators.

In other words, IMHO it would be nicer to have the LiveData conversion separate from this operator.

For example:

private val all = templatesDao.getAll()
val allLiveData = all.asLiveData()

suspend fun example() {
    val newTemplates = getTemplatesFromFirestore(all.first())
    templatesDao.insert(newTemplates)
}

[Se7eN]

I see. The only reason for using collect was because I wanted to update the list when it's first loaded. I get it now, this looks good!