https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
s

Shashank

09/13/2020, 5:57 PM
Hey everyone! I am trying to test my 
StateFlow
 by asserting the list of values received by it.
data class State(val isLoading: Boolean, val name: String?)

fun main() {
    val mutableStateFlow = MutableStateFlow(State(false, null))
    val stateFlow = mutableStateFlow as StateFlow<State>

    val scope1 = CoroutineScope(Job())
    val scope2 = CoroutineScope(Job())

    scope1.launch {
        delay(1000)
        mutableStateFlow.value = State(true, null)
        mutableStateFlow.value = State(false, "name")
    }

    scope2.launch {
        stateFlow.collect {
            println("value = $it")
        }
    }
    Thread.sleep(2000)
}
Here is my code. Instead of getting 
State(true, null)
 as the second value, I only receive the initial value and the last value (
State(false, name)
)
a

araqnid

09/13/2020, 6:00 PM
I found sticking a
delay(10)
between the two writes to
mutableStateFlow.value
showed the intermediate state. Presumably it’s a race condition, the intermediate state is being overwritten before it’s been published
in fact, even just a
yield()
is enough on my test machine
z

Zach Klippenstein (he/him) [MOD]

09/13/2020, 6:07 PM
There are no suspending calls between setting the two states, so they are immediately set one-after-the-other, before your collector has a chance to resume.
StateFlow
conflates such values, so the intermediate value will never be seen. Steve’s suggestions add a suspend point between the two calls, which gives your collector a chance to resume.
To test this sort of thing, I usually use an explicit trigger to make the test more explicit. Something like:
val finishLoad = Job()
…
mutableStateFlow.value = State(true, null)
finishLoad.join()
mutableStateFlow.value = State(false, "name")
…
assertEquals(State(true, null), collectingChannel.receive())
assertTrue(collectingChannel.isEmptyForReceive)
finishLoad.complete()
assertEquals(State(false, "name"), collectingChannel.receive())
assertTrue(collectingChannel.isEmptyForReceive)
a

Adam Powell

09/13/2020, 6:16 PM
perhaps higher level, when working with observable state it should never matter for an observer's correctness if it doesn't see intermediate states. (If you're just trying to test that your emitter is performing all of the updates it should, that's another matter)
☝️ 2
s

Shashank

09/13/2020, 7:06 PM
So I am replacing my Behaviour Subject with StateFlow. And I find this behaviour (heh) very undesirable. I don’t think StateFlow should conflate the values. Instead, it should be left to the consumer. What if I want to show something to the user when I receive the exact same state updates. @Adam Powell Yes I do want to verify if my emitter is performing all the updates. I am using an MVI pattern and so I do want to verify the intermediate states as well. I do agree that sticking a 10 milli delay does “fix” this but I was thinking if there is a better way?
z

Zach Klippenstein (he/him) [MOD]

09/13/2020, 8:33 PM
I don't think adding a delay fixes anything, it's a hack that hides the core issue, which is probably that the data you're using this for isn't really state but events. State, by nature, doesn't matter if you conflate it. If you start out in state A, then end up in state C, it doesn't matter if there was a state B in the middle there somewhere - the final state is still C. StateFlow is meant for state, and so it makes assumptions like this which are only valid for state. There is another type, SharedFlow, which hasn't been released yet but is suitable for event data where every emission is meaningful. It does not conflate items itself. Unfortunately, it is only scheduled for the 1.4 release of coroutines, and there has been no communication on when that is going to happen. Until it is released, your best option is to use BroadcastChannel for events.
5
s

Shashank

09/13/2020, 10:35 PM
State, by nature, doesn’t matter if you conflate it. If you start out in state A, then end up in state C, it doesn’t matter if there was a state B in the middle there somewhere
Well, doesn’t this make testing a bit difficult? Let’s say I set
state = State(false, emptyList)
. Then I call a function which sets
state = State(true, emptyList)
. The state flow will only give me the second value if there is very little time difference between the two. So wouldn’t I need to know about the implementation of my SUT and know at which points is the state set without any dealy?
your best option is to use BroadcastChannel for events.
I don’t think it re-emits the latest value to new subscribers. So I can’t really use it for my view state stream.
a

Adam Powell

09/13/2020, 11:06 PM
no, it tends to make testing easier. State observers should always be idempotent and any one state snapshot from the stream should be sufficient to produce a correct result. For cases where you are testing a state emitter's precise behavior you can collect the flow using the unconfined dispatcher.
☝️ 1
z

Zach Klippenstein (he/him) [MOD]

09/13/2020, 11:35 PM
I think unit tests generally should only test individual state transitions (otherwise you're not really writing a unit test). If you do want to test multiple transitions for some reason, then you should have some way to explicitly trigger transitions like I gave an example for above.
a

Anvith

09/14/2020, 3:49 AM
@Adam Powell Expecting idempotent behaviour from downstream listeners is a different thing than processing/emitting all states in the current stream don't you think? This seems like a slippery slope for making assumptions on what downstream listeners should/shouldn't receive.
a

Adam Powell

09/14/2020, 1:48 PM
In the case of state the two are related. Only the current value matters, whether you receive that value multiple times or if it changes several times before you sample it. Could you elaborate on the slippery slope part?
a

Anvith

09/15/2020, 5:10 AM
Isn't the API contract an emission contract as well ( i.e. i send stuff you store it and send it to others) not just a persistence contract? I think when you speak purely of state may be what you say is true however when we talk of propagation of state I feel making this assumption seems like short circuiting. Regarding this`Could you elaborate on the slippery slope` Anything particular you were seeking since I was pointing to StateFlow making assumptions on emission sequence. For e.g. some downstream frameworks could be stateful( eg. animations) and rely not just on an absolute state but also on the transition(something which is a sideeffect/computed property of succesive state emissions).