https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
v

Vipul

07/22/2020, 5:41 PM
I am trying to test below method and assert that
remoteCloudDataStore.getFoodItems()
and
localDataStore.addFoodItems(it)
methods are called
exactly once
fun getFoodItems(forceNetworkFetch: Boolean) = remoteCloudDataStore.getFoodItems().flatMapConcat {
        localDataStore.addFoodItems(it).flatMapConcat {
            flow { emit(FoodResult.Success(it)) }
        }
    }.flowOn(<http://dispatcher.io|dispatcher.io>)
Below is my test case
repository.getFoodItems(true).collect {
            verify(exactly = 1) { remoteCloudDataStore.getFoodItems() }
            verify(exactly = 5) { localDataStore.addFoodItems(any()) }
        }
Surprisingly this test case pass, even if addFoodItems() method is not being called 5 times, can someone point me in correct direction what I am doing wrong here? I am passing
TestCoroutineDispatcher
during testing.
l

Luis Munoz

07/22/2020, 5:48 PM
for a test I would do
repository.getFoodItems(true).toList() verify(exactly = 1) { remoteCloudDataStore.getFoodItems() } verify(exactly = 5) { localDataStore.addFoodItems(any()) }
j

Justin Tullgren

07/22/2020, 5:57 PM
Those are both terminal in my understanding (collect/toList) so why would collect not work? Maybe coVerify is needed here and not just normal verify when using mockk
v

Vipul

07/22/2020, 6:00 PM
even after coVerify test passes, my expectation is this test should fail, because
localDataStore.addFoodItems
is not being called 5 times in method body.
If I do
toList()
I receive:
io.mockk.MockKException: Missing calls inside verify { ... } block.
j

Justin Tullgren

07/22/2020, 6:04 PM
Sorry @Luis Munoz code looks correct to me so I guess I can't help any more. I would be interested in what you find though if you care to share in the future
l

Luis Munoz

07/22/2020, 6:14 PM
remoteCloudDataStore.getFoodItems() returns a flow
verify(exactly = 1) { remoteCloudDataStore.getFoodItems().toList() }
probably wrong you want to see how many items are in the list?
v

Vipul

07/22/2020, 6:16 PM
I am more curious about how to verify method interaction
how many items
test case is planned for sure 🙂
l

Luis Munoz

07/22/2020, 6:17 PM
if remoteCloudDataStore.getFoodItems() returns a flow you gotta terminate it
that is why I suggest you use toList to terminate everything
before doing assertions
v

Vipul

07/22/2020, 6:20 PM
repository.getFoodItems(true).collect {
coVerify(exactly = 1) { remoteCloudDataStore.getFoodItems().toList() }
coVerify(exactly = 5) { localDataStore.getFoodItems().toList() }
}
Didn’t help
Test case still passes
l

Luis Munoz

07/22/2020, 6:24 PM
assertThat(remoteCloudDataStore.getFoodItems().toList().size).isEqualTo(1)
assert localDataStore.getFoodItems().toList().size  is equal to 5
j

Justin Tullgren

07/22/2020, 6:25 PM
he wants to check the number of calls to his mock dependency. I believe you had it right the first time.
val items = repository.getFoodItems(true).toList()
verify(exactly = 1) { remoteCloudDataStore.getFoodItems() }
l

Luis Munoz

07/22/2020, 6:25 PM
there isn't enough information
are you using runBlocking?
j

Justin Tullgren

07/22/2020, 6:26 PM
or runBlockingTest
I tried with both runBlocking & runBlockingTest
On debugging i am seeing that it doesn’t come other collect method.
repository.getFoodItems(true).collect {
            verify(exactly = 11) { remoteCloudDataStore.getFoodItems() }
        }
l

Luis Munoz

07/22/2020, 7:42 PM
@Test
    fun `force fetching foodItems makes network and db call`() =   {
      val latch = CountDownLatch(1)
      dispatcher.runBlockingTest {

        coEvery { restApi.getFoodItems() } returns MockData.foodItems
        every { localDataStore.addFoodItems(any()) } returns flow { MockData.foodItem }

        repository.getFoodItems(true).collect {
        
            verify(exactly = 11) { remoteCloudDataStore.getFoodItems() }
            latch.countDown()
            
        }
        
        
    }
     
      latch.await(3, TimeUnit.Seconds)
    
    }
never used TestCoroutineDispatcher so I'm not sure. Just make sure 1) that it actually calls the assertion (put a print statement before and after it). 2) that if an error gets thrown it is propagated not swallowed (do a throw RuntimeException and see that test fails and shows exception 3) that everything isn't async and just passes right through the test even when work is still being done in a background thread, you can use CountDownLatch to mark these points
doing assertion inside of collect seem wrong to me
if you only emit once why is it a flow and not a just a suspend, and if you emit more than once then how can you assert multiple times different items
j

Justin Tullgren

07/22/2020, 7:58 PM
@Vipul just to be clear, you verified in a runBlocking statement AFTER the call to collect?
val items = repository.getFoodItems(true).toList()
verify(exactly = 1) { remoteCloudDataStore.getFoodItems() }
IE verify after the flow has terminated
yes I am verifying under collect
j

Justin Tullgren

07/22/2020, 7:59 PM
That does not look like what you Luis is saying. you are verifying in the collect lambda
Did you try this:
coEvery { restApi.getFoodItems() } returns MockData.foodItems
every { localDataStore.addFoodItems(any()) } returns flow { MockData.foodItem }

repository.getFoodItems(true).toList()
verify(exactly = 11) { remoteCloudDataStore.getFoodItems() }
v

Vipul

07/22/2020, 8:02 PM
yup, didnt worked
repository.getFoodItems(true).toList()
verify(exactly = 11) { remoteCloudDataStore.getFoodItems() }
l

Luis Munoz

07/22/2020, 8:02 PM
also you are doing
remoteCloudDataStore.getFoodItems().flatMapConcat
but getFoodItems is a mock object?
so it doesn't have flatMapConcat
v

Vipul

07/22/2020, 8:03 PM
nope, I am having mock on
restApi.getFoodItems()
level
remoteCloudDataStore = CloudCloudDataStoreImpl(restApi)
so following gets called
restApi.getFoodItems()
l

Luis Munoz

07/22/2020, 8:04 PM
project looks interesting i'll clone it and run it in a few minutes
🙏 1
first notice that
@Test
    fun `force fetching foodItems makes network and db call`() =

            dispatcher.runBlockingTest {

        coEvery { restApi.getFoodItems() } returns MockData.foodItems
        every { localDataStore.addFoodItems(any()) } returns flow { MockData.foodItem }

        repository.getFoodItems(true).collect {

            throw RuntimeException("test should fail")
            verify(exactly = 11) { remoteCloudDataStore.getFoodItems() }
        }
    }
does not fail
@Test
    fun `force fetching foodItems makes network and db call`() =

            dispatcher.runBlockingTest {

        coEvery { restApi.getFoodItems() } returns MockData.foodItems
        every { localDataStore.addFoodItems(any()) } returns flow { MockData.foodItem }

        repository.getFoodItems(true).toList()

          //  throw RuntimeException("test should fail")
            coVerify(exactly = 11) { remoteCloudDataStore.getFoodItems().toList() }

    }
is probably what you want
override fun getFoodItems(forceNetworkFetch: Boolean): Flow<FoodResult<List<FoodItem>>>
that signature is making the code overly complicated in my opinion
do you need to stream out multiple lists as a flow or can you just return a list of the collected items
v

Vipul

07/22/2020, 9:10 PM
I got your point, I can refactor it to just return list
but I am curious about this failed test 😄
did it run for you?