https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
r

rt

06/07/2020, 7:13 AM
Hi. How do I figure out that the downstream is exhausted (completed/whatever the right terminology is) in a flow builder? This is the code I currently have: https://pl.kotl.in/tCjm9ICUp - it will time out because my loop condition is obviously not working. In general, what I'm trying to do is have this
while (...) { delay(1000); emit(buffer); buffer.clear() }
to have timed buffering. I'm aware there are operators for this, just trying to figure things out for myself. Also, any other notes on pitfalls of my implementation would be appreciated.
f

fatih

06/07/2020, 9:49 AM
There is no way to understand if the collector is finished or not in flow builder by design. The thing is Flow is cold and when you emit a value in flow builder, it just sends the value to collector side and it is done. There is no buffer in Flow as you mentioned. (There is buffer operator but it buffers the emission and runs the collector in a separate coroutine) If you want a Flow with a buffer like you mentioned use
StateFlow
. By the way can you give a bit more details about use case and why do you need to clear buffer?
r

rt

06/07/2020, 9:51 AM
@fatih, i'm saying 'buffer' to refer to the buffer in my code. I'm doin batching in time - the code at the link is pretty much self-explanatory, so I'm not exactly wondering how to literally get an event for flow completion but rather how to build a flow that will somehow know that the upstream will not send any more elements
f

fatih

06/07/2020, 9:56 AM
If I understand correctly I think you can achieve this in the collector side. If you cancel the scope that you use to collect the flow, you will not get any elements.
r

rt

06/07/2020, 9:57 AM
What do you mean? I don't think that answers my question...
f

fatih

06/07/2020, 12:12 PM
Sorry for confusion.Let me give an example.
val scope = CoroutineScope(<http://Dispatchers.IO|Dispatchers.IO>)
    val testFlow = flow {
        repeat(5) {
            emit(it)
        }
    }
    scope.launch {
        testFlow
            .collect {
                // Check your condition about when to cancel 
                // After you call cancel, isActive becomes false
                if (it == 2) cancel()
                
                // If this coroutine is active do your thing
                if (isActive) {
                    println(it)
                }
            }
    }
Here in collect you can check your cancellation condition and do your stuff if the coroutine is only active
r

rt

06/07/2020, 12:14 PM
I'm not looking for conditional cancelation based on element value - I don't want to cancel at all actually. Let me think on this some more and maybe when I have an answer on my own, I'll post an update here.
👍 1
FWIW, this is what I came up with and didn't actually need the
while (isActive)
part. Not sure how efficient this is now, but anyway: https://pl.kotl.in/fJNkH2kWc
What it does is send elements downstream in chunks of up to a given buffer size. If buffer size is exceeded, it's sent immediately, but if we didn't see a fresh element for a given amount of time, we will send whatever we have.
z

Zach Klippenstein (he/him) [MOD]

06/07/2020, 2:05 PM
Don't you also need to cancel the timed send job in the first branch of that if statement? Currently if you send
n
elements and then timeout, you'll send the buffer but also send an empty list after the timeout.
1
r

rt

06/07/2020, 3:49 PM
@Zach Klippenstein (he/him) [MOD] yeah, i also discovered this while running some tests, but now i don't like that i'm basically launching a coroutine on every element. i actually came up with a workaround, maybe will publish after polishing
here's an attempt at doing this as i originally intended, with a single additional coroutine (at a cost of a couple more allocations) https://gist.github.com/tkroman/96bda51583893aa8135a4bf890348650 the idea is to first pass the flow through another flow that will emit a dummy marker value at the end of stream so that i'll know when to stop the coroutine at the next stage it's not pretty and it's hard for me to reason which one would be more performant but this version is so dirty i almost like it better 🙂
z

Zach Klippenstein (he/him) [MOD]

06/07/2020, 5:07 PM
I personally prefer the first version. It's much simpler and easier to read and reason about. There's nothing inherently wrong with launching a new coroutine on each element, especially when it makes the code so readable. I'm pretty sure there are some operators in the coroutines library that use this technique too. Launching a coroutine effectively amounts to just making a few allocations anyway. It's also pointless to speculate about performance without benchmarking.
2
r

rt

06/07/2020, 6:57 PM
mm... pointless is a strong word though. you realistically can at least ballpark performance implications. if the flow is data-intensive (say you capture mouse movements at a high rate), it doesn't matter how cheap allocations are, they are still there, and in my book
less allocations
>
more allocations
. i'm still on the fence wrt intermediate stream anyway, but think i can rely on fusion here. probably should benchmark anyway
but i was also not precisely correct abt 'new coroutine on every element', it's actually 'on every flush' so under realistic conditions not too often... benchmarks it is
z

Zach Klippenstein (he/him) [MOD]

06/07/2020, 7:11 PM
Sorry, maybe “pointless” was too harsh. What I meant was that I’m not convinced your assumption about allocation comparisons is correct, since starting new coroutines is also pretty cheap and basically amounts to “just a few allocations” itself. And optimizing complicated code is harder than optimizing simple code, so until you’ve actually found real performance issues, it’s better to prefer simpler code.
1
r

rt

06/08/2020, 6:58 AM
yup, totally agree there 🙂
I ran some tests earlier today, nothing fancy, not using jmh etc etc, but simply aggregating after chunking a stream of 1M elements, cleaner version is ~3x slower.