https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
s

Sean Keane

05/01/2020, 4:11 PM
Hi All, Im writing some test code and I seem to be having issues with Coroutines. I want to make a request to
Login
but it calls the function and kicks it off on a new Coroutine. This causes the test to continue and hit the verify BEFORE the request is made. Im working in Multiplatform and using Coroutine testing tools in Android as a target for the tests. This is my test:
class KAuthenticationServiceTest {

    var loginRequest = service.auth.login.build("<mailto:fakeEmail@mail.com|fakeEmail@mail.com>", "fakePassword")

    var mockStorage = MockStorage()
    var mockCredentialsManager = MockCredentialsManager()
    var mockNetworkManager = MockNetworkManager()
    lateinit var authService: AuthService

    @BeforeTest
    fun setup() {
        authService = KAuthenticationService(
            storage = mockStorage,
            credentialsManager = mockCredentialsManager,
            networkManager = mockNetworkManager
        )
    }

    /**
     * Given:   A user requests to login
     * When:    The call is made to the login interactor
     * Then:    The request is executed successfully
     */
    @Test
    fun callIsMadeToLoginInteractorToExecuteRequest() = runTest {
        authService.login(loginRequest, {}, {})
        assertTrue {
            mockNetworkManager.requestValue == loginRequest
        }
    }
}
The run test function in Android is the following:
val mainThreadSurrogate = newSingleThreadContext("UI thread")

actual fun <T> runTest(block: suspend () -> T) {
    Dispatchers.setMain(mainThreadSurrogate)
    runBlockingTest {  block() }
}
Im a bit lost as to how I can get the runBlocking to run the authService.login on the same thread so it blocks until executed and then continues to the assert? Has anyone got any suggestions?
l

Luis Munoz

05/01/2020, 8:47 PM
how does authService.login look
should probably be suspend fun login()
sounds like you are doing a launch inside of it and it passes right through it
s

Sean Keane

05/01/2020, 8:51 PM
This is my interactor:
internal class LoginInteractor(
    private val loginRequest: LoginRequest,
    private val onSuccess: (Unit) -> Unit,
    private val onError: (KarhooError) -> Unit,
    context: CoroutineContext = Dispatchers.Main,
    private val credentialsManager: CredentialsManager,
    private val networkManager: NetworkManager
) :
    BaseCallInteractor<Credentials>(
        requestRequiresToken = false,
        context = context,
        credentialsManager = credentialsManager,
        onError = onError
    ) {

    override suspend fun makeRequest() {
        networkManager.request(loginRequest).fold(onError, ::onSuccess)
    }

    private fun onSuccess(credentials: Credentials) {
        credentialsManager.saveCredentials(credentials)
        onSuccess.invoke(Unit)
    }

}
It has a base class of this so far.
internal abstract class BaseCallInteractor<RESPONSE> protected constructor(private val requestRequiresToken: Boolean,
                                                                           private val credentialsManager: CredentialsManager,
                                                                           private val onError: (KError) -> Unit,
                                                                           private val context: CoroutineContext,
) {

    internal abstract suspend fun makeRequest()

    fun execute() {
        GlobalScope.launch(context) {
            // TODO CHECK IF TOKEN IS EXPIRED
            if (shouldRefreshToken()) {

            } else {
                makeRequest()
            }
        }
    }

    private fun shouldRefreshToken(): Boolean {
        //requestRequiresToken && !credentialsManager.isValidToken
        return false
    }

    private suspend fun successfulCredentials(credentials: Credentials) {
        credentialsManager.saveCredentials(credentials)
        makeRequest()
    }

}
l

Luis Munoz

05/01/2020, 8:58 PM
Sorry I don't understand your code. Looks like you using callbacks but when you use coroutines it should look sequential, so you wouldn't have callbacks. It should be something like this:
override suspend fun makeRequest(loginRequest: LoginRequest) { val result = networkManager.request(loginRequest) if(result == sucess) { onSuccess } else { onError } }
a callback passes right through the call and calls a function when it completes
a coroutine suspends until the callback is called
so the flow looks sequential
s

Sean Keane

05/01/2020, 9:02 PM
Yep, Its part of a lib im building that the user passes in the Request and the onSuccess lambda and onError lambda. I think your right. Ill give it a go tomorrow. I know it works currently so I just need to make it more testable. This is a POC before we roll it out so I need to lock down a pattern before we shift our SDKs to KMP