https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
b

Brendan Weinstein

02/24/2020, 9:10 AM
How do I synchronize the dispatchAction function below so that it only starts sending items once there is a downstream collector? onStart unfortunately get called right before collect.
class StateMachine(val scope: CoroutineScope) {  

  private val inputActions: BroadcastChannel<Rankings.Action> = BroadcastChannel(Channel.BUFFERED)
  private var isInitialized = atomic(false)

  init {
    scope.launch {
      inputActions.asFlow()
        .onStart { isInitialized.value = true //onStart hook is called just before collect gets called }
        .collect { action ->
          //handle action
        }
      // CANNOT CALL FUNCTION HERE BECAUSE `collect` SUSPENDS
    }
  }

  fun dispatchAction(action: Rankings.Action) = scope.launch {
    while(!isInitialized.value) {
    }
    inputActions.send(action)
  }
}
k

Kiryushin Andrey

02/24/2020, 9:56 AM
What is you intention for actions dispatched before initialization happens? Do you want them to get lost or to get buffered in channel and consumed later when a collector gets attached to the flow? Also I can't quite get how could
dispatchAction
get called before a downstream collector is attached, for it is attached right in the class constructor.
u

uli

02/24/2020, 12:57 PM
@Kiryushin Andrey a job is launched in the constructor to attach the collector. This is not the same as the collector being attached in the constructor
k

Kiryushin Andrey

02/24/2020, 1:00 PM
Oh, right, I've overlooked that, thank you for noticing
Not sure though what behavior is desired for the
dispatchAction
method while initialization hasn't yet completed. If it should just drop actions while a collector isn't there, then simple condition check like the following will do:
if (isInitialized.value) {
    inputActions.send(action)
}
b

Brendan Weinstein

02/24/2020, 4:43 PM
The desired behavior is for send to suspend until the first collector has subscribed to upstream events
This is a code pared down a little bit from implementing an mvi/redux-like pattern for mobile. Events are dispatched from the view and get pipelined through a scan operator that spits out a Flow of ViewState's back to the view
u

uli

02/24/2020, 4:47 PM
how about making inputActions a
Deferred<BroadcastChannel<Rankings.Action>>
and then:
fun dispatchAction(action: Rankings.Action) = scope.launch {
    inputActions.await().send(action)
  }
b

Brendan Weinstein

02/24/2020, 4:52 PM
ooo like that idea. I will give that a try and report back
ah sorry -- I was overly optimistic and responded while walking to work! I guess the crux of the question is how to define a hook for when the first collector starts collecting on a flow. I probably should have framed the question that way from the get-go
The challenge is that collect is a suspending function, so you must call it within a coroutine and you cannot execute any code after the collect call.
@InternalCoroutinesApi
fun main() {
    val channel = BroadcastChannel<Int>(Channel.BUFFERED)

    GlobalScope.launch {
        var i = 0
        delay(10_000)
        while (true) {
            delay(1000)
            channel.send(i)
            i++
        }
    }

    GlobalScope.launch {
        val flow = channel.asFlow().asBindFlow {
            println("onBind")
        }

        delay(5000)
        println("adding terminal downstream collector")
        flow.collect {
            println("collected: $it")
        }
    }
    while(true) {

    }
}

@InternalCoroutinesApi
fun <T> Flow<T>.asBindFlow(onBind: () -> Unit): Flow<T> {
    return BindFlow(onBind = onBind, flow = this)
}

@InternalCoroutinesApi
class BindFlow<T>(val onBind: () -> Unit, val flow: Flow<T>) : Flow<T> {
    private var hasBinded = AtomicBoolean(false)
    private val mutex = Mutex()

    @InternalCoroutinesApi
    override suspend fun collect(collector: FlowCollector<T>) {
        if (!hasBinded.get()) {
            mutex.withLock {
                if (!hasBinded.get()) {
                    onBind()
                    hasBinded.set(true)
                }
            }
        }
        flow.collect {
            collector.emit(it)
        }
    }
}
And we can avoid the mutex in BindFlow with compareAndSet
@InternalCoroutinesApi
class BindFlow<T>(val onBind: () -> Unit, val flow: Flow<T>) : Flow<T> {
    private var hasBinded = AtomicBoolean(false)

    @InternalCoroutinesApi
    override suspend fun collect(collector: FlowCollector<T>) {
        if (hasBinded.compareAndSet(false, true)) {
            onBind()
        }
        flow.collect {
            collector.emit(it)
        }
    }
}