https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
d

diesieben07

01/30/2020, 9:09 PM
If I create a
Job
with a parent (parent is long-running), is it a memory/resource leak to not complete or cancel the Job? Will the parent hold on to it and prevent it from being garbage collected?
o

octylFractal

01/30/2020, 9:10 PM
yes
since the parent is required to cancel all child jobs when it itself is cancelled
d

diesieben07

01/30/2020, 9:12 PM
Hm. That sucks 😄 How do I best deal with this situation? The parent job is a
SupervisorJob
for a service implementation. When the service gets a request, I start a child job for that request. This handle is handed out to third party code, how do I ensure that I clean up my job if the third party code fails / throws an exception?
s

streetsofboston

01/30/2020, 9:20 PM
Do you return the
Job
of each request to the caller? If so, why?
d

diesieben07

01/30/2020, 9:24 PM
// third party code
interface Callback {
  fun onMessage(message: Any)
  fun onComplete()
}

// my code
class MyService : ThirdPartyInterface {
  val job = SupervisorJob()
  
  override fun someOperation(responseListener: Callback): Callback {
    val requestJob = Job(job)
    return object : Callback {
       // handle onMessage, etc. here. write responses to responseListener
       // this spawns processing coroutines using requestJob
       // as such I must ensure to properly dispose of it...
    }
  }
}
o

octylFractal

01/30/2020, 9:26 PM
typically you should adapt the callback to a suspend function, see https://medium.com/@elizarov/callbacks-and-kotlin-flows-2b53aa2525cf
s

streetsofboston

01/30/2020, 9:26 PM
To avoid tracking your Jobs in your own code, use CoroutineScopes instead.
o

octylFractal

01/30/2020, 9:28 PM
tbh, I think that for this style of interface, you should be launching an independent job for each callback, with no parent
d

diesieben07

01/30/2020, 9:28 PM
I want a parent job for all requests though, how do I do that with CoroutineScope?
How do I then close this service?
If I dont have a parent...
o

octylFractal

01/30/2020, 9:29 PM
well,
CoroutineScope
always contains a Job
d

diesieben07

01/30/2020, 9:29 PM
I know that.
o

octylFractal

01/30/2020, 9:29 PM
you can pass
SupervisorJob
to have a parent
doesn't really change anything about the cancellation though
I think I don't know enough to say what the appropriate step is here
d

diesieben07

01/30/2020, 9:30 PM
Even if I use
CoroutineScope
it doesn't solve my problem, because now I need to properly dispose of that.
s

streetsofboston

01/30/2020, 9:30 PM
CoroutineScopes do solve your issues. They keep track of Jobs and cancel/dispose of them properly
d

diesieben07

01/30/2020, 9:30 PM
I know about coroutine scope and I know how it works. But it doesn't solve the problem of having to hand out stuff to other code, which is written in Java and not aware of coroutines.
s

streetsofboston

01/30/2020, 9:31 PM
Let me take a quick peek at your code snippet and see how you could use CoroutineScopes to manage Jobs
You should not return Jobs… return Futures instead (CompletableFutures)
d

diesieben07

01/30/2020, 9:33 PM
I can't return a future.
ThirdPartyInterface
is a callback-based API.
someOperation
is an implemenation of a third-party interface.
o

octylFractal

01/30/2020, 9:33 PM
is it possible for us to see the full interface?
c

Casey Brooks

01/30/2020, 9:34 PM
The reason you’d typically want to hold onto a
Job
is so that you can cancel it in response to application lifecycles. Otherwise, coroutines will tidy themselves up. To handle other code, you should find some way to “bind” it to the world of coroutines. You can wrap a callback-based API into a coroutine with `suspendCancellableCoroutine`:
suspendCancellableCoroutine<String> { cont ->
    someJavaMethodWithACallback { cont.resume(it) }
}
https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines/suspend-cancellable-coroutine.html
And before you say "you should use a coroutine-aware grpc generator", that is what I am working on.
@Casey Brooks
suspendCancellableCoroutine
requires me to be in a suspending function already. And it is also just a one-off. There can be many messages going in and out of the callbacks
o

octylFractal

01/30/2020, 9:37 PM
it looks like Listener allows you to bind
onCancel
/
onComplete
I would just bind those to closing the job, and not worry about it if those never get called
d

diesieben07

01/30/2020, 9:37 PM
That's quite optimistic in a network scenario 😄
o

octylFractal

01/30/2020, 9:38 PM
if those don't get called, I would consider that a bug in grpc
considering: Cancellations can be caused by timeouts, explicit cancellation by the client, network errors, etc.
even in a network scenario, grpc claims
onCancel
will be called
c

Casey Brooks

01/30/2020, 9:38 PM
Flow
might be closer to what you’re wanting than a raw coroutine
s

streetsofboston

01/30/2020, 9:39 PM
class MyService : ThirdPartyInterface {
    val job = SupervisorJob()
    override fun someOperation(responseListener: Callback): Disposable {
        val scope = CoroutineScope(job)
        return object : Disposable {
            override fun dispose() {
                scope.cancel()
            }

        }
        scope.launch {
            // handle onMessage, etc. here. write responses to responseListener
            // this spawns processing coroutines using requestJob
            // as such I must ensure to properly dispose of it...
        }
    }
}
d

diesieben07

01/30/2020, 9:39 PM
Again, you are changing what I am returning... which I can't do.
thank you Octavia, it seems I was a bit to pessimistic maybe. I'll follow your advice.
s

streetsofboston

01/30/2020, 9:39 PM
You need something to be cancelled by the caller.
It the caller can’t cancel it, you can still return the Callback and have it properly cleaned up on exceptions or finishing of the requests
class MyService : ThirdPartyInterface {
    val scope = CoroutineScope(SupervisorJob())
    override fun someOperation(responseListener: Callback): Callback {
        scope.launch {
            // handle onMessage, etc. here. write responses to responseListener
            // this spawns processing coroutines using 'scope'
            // as such I must ensure to properly dispose of it...
        }
        return responseListener
    }
}
d

diesieben07

01/30/2020, 9:42 PM
Thanks everyone for your replies
s

streetsofboston

01/30/2020, 9:44 PM
In my last example code above, when code inside the
launch
throws an exception, or just finishes, any Jobs associated with it will be cancelled/clean-up and garbage collected. The CoroutineScope will take care of that You may want to install a CoroutineExceptionHandler in the constructor of he
CoroutineScope
as well, to handle any unhandled/un-caught exceptions….
d

diesieben07

01/30/2020, 9:46 PM
Yes, I know about CoroutineScope
s

streetsofboston

01/30/2020, 9:46 PM
But won’t it solve your problem of possibly leaking Jobs?
d

diesieben07

01/30/2020, 9:48 PM
My problem was that I thought I didn't have a "I am done" callback on my third party interface, when in fact I do.
s

streetsofboston

01/30/2020, 9:50 PM
Ah! I see! 🙂