Hi, I have a method in repository that is just cal...

# coroutines

[david.bilik]

Hi, I have a method in repository that is just calling some api request through retrofit and I want to solve a situation when this method is called multiple times at the same time and it fires multiple requests. Ideal solution for me would be to somehow reuse the same request while it runs. I’ve come up with this but I dont know if there are any problems or if it does not make sense at all. Thanks

original function

override suspend fun user(): User {
	return api.user()
}

suggested solution

var userDeferred: Deferred<User>? = null

override suspend fun user(): User {
    if (userDeferred == null) {
        userDeferred = async {
            apiInteractor.user()
        }
    }
    return userDeferred.await().also {
        userDeferred = null
    }
}

[uhe]

That won't compile because userDeferred is a nullable property, so userDeferred.await() is not allowed.
Furthermore, you can still get multiple concurrent calls, because the check for null and the assignment are not atomic (if this function is called from different threads).

[uhe]

For simple serialization of api calls you could use a Mutex and wrap the whole body in a mutex.withLock .
However, actually piggy-backing on in-flight calls would require another solution.

[david.bilik]

that was just a little polished pseudode, i’ve put some ‼️ while testing it so it compiles .. and yes, i would need to synchronize it to actually have it safe .. but ok, i’ll take a look at the Mutex solution, thanks