https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
l

Luke Rohde

12/03/2019, 6:25 PM
is there anything wrong with doing cleanup like this in a flow builder block?
flow {
  for (i in collection) {
    try {
      emit(i)
    } finally {
      doCleanupOn(i)
    }
  }
}
is there a better way to accomplish this?
o

octylFractal

12/03/2019, 6:34 PM
I'd say that this is the preferred way to do it
l

Luke Rohde

12/03/2019, 6:35 PM
cool. and this will have the semantics that the suspension will only continue once whatever downstream of this call to emit is completed?
or put another way, when does the suspension from emit continue
r

Ricardo

12/03/2019, 6:36 PM
AFAIK, it's not a good practice to have your
emits
between
try-catch
You can use the
.catch
operator to catch any exception from the upstream
If you leave that
try-catch
, you'll be risking funky behaviour like catching an exception thrown by an operator in the downstream, or even thrown by the terminal operator
Then again, you're using
finally
and no
catch
. You don't expect any exceptions?
l

Luke Rohde

12/03/2019, 6:38 PM
actually thinking through this i don’t want the finally
i think i just want emit then cleanup
r

Ricardo

12/03/2019, 6:39 PM
There's an
onCompletion
operator
And yeah, if you don't expect any trouble there, I guess you could just do the cleanup right after the emission
l

Luke Rohde

12/03/2019, 6:40 PM
is onCompletion equivalent to that?
oh no, bc that doesn’t give access to the element
which is what i’m lookign for
r

Ricardo

12/03/2019, 6:42 PM
onCompletion
does the same as having your flow's collection inside a
try-finally
l

Luke Rohde

12/03/2019, 6:42 PM
except it doesn’t have the element in scope
r

Ricardo

12/03/2019, 6:42 PM
Yup
If you won't have access to those elements at the end, then you can't use it
Can´t you just do
flow {
  for (i in collection) {
      emit(i)
      doCleanupOn(i)
  }
}
?
l

Luke Rohde

12/03/2019, 6:44 PM
yeah exactly
that’s what i’m doing
r

Ricardo

12/03/2019, 6:45 PM
Solved then 😛
l

Luke Rohde

12/03/2019, 6:45 PM
assuming the semantics are what i said above, which is that all downstream operations on the flow complete before it resumes to doCleanupOn
thanks for your help!
r

Ricardo

12/03/2019, 6:55 PM
No problem, happy to do so 😊
c

codeslubber

12/03/2019, 9:28 PM
I think this thread is endemic of a problem with coroutines: they present as a way to solve the worst flow problems of concurrency, but do they? or like most things, do they just mean you have to find new ways to accommodate same?
o

octylFractal

12/03/2019, 9:31 PM
I am not sure what you mean by that. In general they claim to solve the issues of non-sequential-like async programming, but being able to
emit(i)
and then immediately call
doCleanupOn(i)
is very sequential-like, so this seems to be an example of coroutines working well towards their goal
c

codeslubber

12/03/2019, 9:34 PM
But there are still catches, and questions of when and where things will happen.. the means the idea of a deterministic sequence is not really there right?
o

octylFractal

12/03/2019, 9:47 PM
I feel like that's more like an question of Flow in particular, which is separate from coroutines. And the model is fairly simple, downstream flows pass in a FlowCollector, the upstream calls
emit(i)
, and in
emit
, the downstream uses the element, processes it, etc. So clearly exceptions from downstream are thrown from
emit
.
catch
's implementation uses
collect
&
emit
,
collect
throws the errors from upstream generation and the
emit
calls, and special handling around emit figures out if exceptions thrown from
collect
are from up or downstream. It's not very complicated at all.
c

codeslubber

12/03/2019, 9:57 PM
One thing is for sure: the solutions, are towers erected in sand. The architecture patterns from 2 years ago looked good, had good MVVM approach, they are mostly dust now, Compose ushered in a whole new approach. You don’t even have time to learn things before they are mothballed. My problem with Rx and its spawns (have not looked enough at flow yet) is that they obscure logic. The argument in the Meyer Bible OOSC is that exceptions are useful for that reason primarily, is pretty compelling, but here we are talking about how you have to figure exactly how to sequence and then gird for upstream emissions. I hope you ARE right because I do think some flow is necessary, but if it overwhelms the code and the logic is every 3rd line, we’re doomed. Might as well go back to C where they had to have if statements on each SDK call, and then block-based handlers for integer return types…
d

Dico

12/04/2019, 7:04 AM
I don't think this is the correct way to do this. The assumption that the element is fully processed after
emit
returns does not apply to some flow operators, namely buffering ones. But it might work in your use case.
👌 1
l

Luke Rohde

12/04/2019, 3:33 PM
is there anything you would recommend short of threading the item through the whole flow?
d

Dico

12/05/2019, 3:11 AM
I dont have an answer.
u

ursus

12/05/2019, 7:16 AM
Hmm, but.. doesnt that presume that the subscriber doesnt switch threads?i.e. if he does, then cleanup will run before subscriber's code, which will then act on a closed instance
feels like the db cursor mapping problem from rxjava, and the result of it was you cannot do it in reactive fashion, you need to map and close it synchronously