How do I convert this into less janky and actually...
# coroutinesk
Kroppeb
09/19/2019, 12:51 PMHow do I convert this into less janky and actually working code
😕 1
Kroppeb
09/19/2019, 12:52 PMThis is the log btw
m
marstran
09/19/2019, 12:57 PMSo, what are you trying to do?
k
Kroppeb
09/19/2019, 1:04 PMI'm reading raw bytes from a ByteReadChannel and if i got a cipher i encrypt and then send those bytes int a different ByteChannel
Kroppeb
09/19/2019, 1:05 PMthe problem is that ByteChannel#Read requires a normal lambda and not a suspending one which is causing all the problems
Kroppeb
09/19/2019, 1:10 PMI fixed it by moving the Job initialiser outside of the while loop 🤦♂️
Kroppeb
09/19/2019, 1:10 PMBut still the code looks jank
Kroppeb
09/19/2019, 1:10 PMI'm extracting it to a extensionfunction for the time being
m
marstran
09/19/2019, 1:11 PMSo the read-lambda is a callback right?
k
Kroppeb
09/19/2019, 1:11 PMyeah
m
marstran
09/19/2019, 1:12 PMOk, then you should convert it to a coroutine with the
suspendCoroutinep
Paulius Ruminas
09/19/2019, 1:12 PMWhich functions are suspending in launch? Maybe you could use a channelFlow instead of the nullable Job to pass the data
k
Kroppeb
09/19/2019, 1:12 PMWhat do you mean?
Kroppeb
09/19/2019, 1:12 PMI'm writing to a second byteChannel
Kroppeb
09/19/2019, 1:13 PMthose writes are suspending
Kroppeb
09/19/2019, 1:14 PMin the future it might be converted into a channel of a certain type but that requires some refactoring and wrappers and i first want my code working
Kroppeb
09/19/2019, 1:14 PMI'm guessing my question is: Is there a variant for read that allows supension?
m
marstran
09/19/2019, 1:15 PMSo something like
Copy code
suspend fun ByteChannel.read(): ByteBuffer = suspendCoroutine { continuation ->
read { continuation.resume(it) }
}k
Kroppeb
09/19/2019, 1:18 PMdoesn't seem to work
Kroppeb
09/19/2019, 1:20 PMmessage has been deleted
Kroppeb
09/19/2019, 1:35 PMthis also feels janky
m
marstran
09/19/2019, 1:49 PMWeird error you get in the first one. You said
readmarstran
09/19/2019, 1:49 PMCould you try renaming your function to
readSuspendingk
Kroppeb
09/19/2019, 1:50 PMread is suspending
m
marstran
09/19/2019, 1:51 PMThe original ByteChannel.read or the one you wrote?
k
Kroppeb
09/19/2019, 1:51 PMboth
m
marstran
09/19/2019, 1:52 PMOh, ok. Then you won't need the suspendCoroutine thing.
marstran
09/19/2019, 1:53 PMWhat library is
ByteChannelmarstran
09/19/2019, 1:55 PMSeems weird to me that a suspending function has a callback as a parameter
k
Kroppeb
09/19/2019, 2:04 PMkotlin.coroutines.io.ByteReadChannel#reade
Evan R.
09/19/2019, 2:26 PMI think the real question here is why are you doing a second nested launch if you just want to wait for the coroutine to complete before starting the next loop iteration?
k
Kroppeb
09/19/2019, 2:34 PMI was doing that cause i didn't know how to do it otherwise
Kroppeb
09/19/2019, 2:34 PMit's gone now
e
Evan R.
09/19/2019, 2:48 PMAlright, should be fine then. I assume that since
readc
Colton Idle
09/20/2019, 3:29 AMWhat's your code look like now @Kroppeb?
k
Kroppeb
09/20/2019, 10:24 AMmessage has been deleted
10 Views