How do I convert this into less janky and actually working c

Question

How do I convert this into less janky and actually working code

Kroppeb · Answer

This is the log btw

marstran · Answer

So what are you trying to do

Kroppeb · Answer

I m reading raw bytes from a ByteReadChannel and if i got a cipher i encrypt and then send those bytes int a different ByteChannel

Kroppeb · Answer

the problem is that ByteChannel Read requires a normal lambda and not a suspending one which is causing all the problems

Kroppeb · Answer

I fixed it by moving the Job initialiser outside of the while loop man facepalming

Kroppeb · Answer

But still the code looks jank

Kroppeb · Answer

I m extracting it to a extensionfunction for the time being

marstran · Answer

So the read lambda is a callback right

Kroppeb · Answer

yeah

marstran · Answer

Ok then you should convert it to a coroutine with the `suspendCoroutine` function Check out this article <https medium com elizarov callbacks and kotlin flows 2b53aa2525cf>

Paulius Ruminas · Answer

Which functions are suspending in launch Maybe you could use a channelFlow instead of the nullable Job to pass the data

Kroppeb · Answer

What do you mean

Kroppeb · Answer

I m writing to a second byteChannel

Kroppeb · Answer

those writes are suspending

Kroppeb · Answer

in the future it might be converted into a channel of a certain type but that requires some refactoring and wrappers and i first want my code working

Kroppeb · Answer

I m guessing my question is Is there a variant for read that allows supension

marstran · Answer

So something like ``` suspend fun ByteChannel read ByteBuffer = suspendCoroutine continuation gt read continuation resume it ```

Kroppeb · Answer

doesn t seem to work

Kroppeb · Answer

this also feels janky

marstran · Answer

Weird error you get in the first one You said `read` isn t suspending right

marstran · Answer

Could you try renaming your function to `readSuspending`

Kroppeb · Answer

read is suspending

marstran · Answer

The original ByteChannel read or the one you wrote

Kroppeb · Answer

both

marstran · Answer

Oh ok Then you won t need the suspendCoroutine thing

marstran · Answer

What library is `ByteChannel` from

marstran · Answer

Seems weird to me that a suspending function has a callback as a parameter

Kroppeb · Answer

`kotlin coroutines io ByteReadChannel read`

Evan R. · Answer

I think the real question here is why are you doing a second nested launch if you just want to wait for the coroutine to complete before starting the next loop iteration

Kroppeb · Answer

I was doing that cause i didn t know how to do it otherwise

Kroppeb · Answer

it s gone now

Evan R. · Answer

Alright should be fine then I assume that since `read` is a suspending function it will wait until new bytes come into the channel before writing out to the output channel

Colton Idle · Answer

What s your code look like now < Kroppeb>

Kroppeb · Answer