Is there any better way to wrap this function in C...

# coroutines

[dave08]

Is there any better way to wrap this function in Caffeine Cache:

suspend fun <K: Any, V> AsyncCache.getSuspending(key: K): V {
    val outerContext = coroutineContext
    return get(key) { k, executor ->
        val innerContext = outerContext + Job() + executor.asCoroutineDispatcher()
        CoroutineScope(innerContext).async {
            loadValue(k) // loadValue is a suspend function defined elsewhere
        }.asCompletableFuture()
    }.await()
}

[Dominaezzz]

suspend fun <K: Any, V> AsyncCache.getSuspending(key: K): V {
    val outerContext = coroutineContext
    return get(key) { k, executor ->
        val innerContext = outerContext + Job() + executor.asCoroutineDispatcher()
        GlobalScope.async(innerContext) {
            loadValue(k) // loadValue is a suspend function defined elsewhere
        }.asCompletableFuture()
    }.await()
}

[Dominaezzz]

or even better,

suspend fun <K: Any, V> AsyncCache.getSuspending(key: K): V {
    val outerContext = coroutineContext
    return get(key) { k, executor ->
        val innerContext = outerContext + Job() + executor.asCoroutineDispatcher()
        GlobalScope.future(innerContext) {
            loadValue(k) // loadValue is a suspend function defined elsewhere
        }
    }.await()
}

[dave08]

But then I loose the parent-child Job relationship (since we're using GlobalScope)? Or did I misunderstand?

[dave08]

Unless providing innerContext does the same?

[Dominaezzz]

Constructing a CoroutineScope without explicitly cancelling it is the same as GlobalScope. Might as well save the allocation.

[Dominaezzz]

Yeah, what you said.

[dave08]

Thanks!