is there a better way to remove the `if(carId.is...

# coroutines

[Hexa]

is there a better way to remove the if(carId.isNullOrEmpty()) statement here as it looks duplicated code to me.
deferredCarIdResult.await() can return an empty string like this "" so I return CarNotFound("not found") but when the coroutines timeout I also return CarNotFound("not found")

val carId = runBlocking {
                    withTimeoutOrNull(10000L) {
                        deferredCarIdResult.await()
                    }
                } ?: return CarNotFound("not found")
                
                if(carId.isNullOrEmpty()){
                    return CarNotFound("not found")
                }

[Dominaezzz]

Remove ?: return CarNotFound("not found")?

[Dominaezzz]

Or add .takeUnless { it.isEmpty() } right after the await.

[Hexa]

thanks I think removing ?: return CarNotFound("not found") is more readable so I'll do that

[Hexa]

if i add .takeUnless { it.isEmpty() } can I lose the if the statement then @Dominaezzz?

[Dominaezzz]

Yes

[Hexa]

would takeUnless be more idiomatic in this case? @Dominaezzz. it's not as readable but i think it just takes getting used to

[Dominaezzz]

Hmm, I'm not sure if it's more idiomatic per se but the more readable option is more idiomatic.

[Dominaezzz]

Short answer is no.

[Hexa]

cool, thank you