`AsyncTask.THREAD_POOL_EXECUTOR`
# coroutinesp
Paul Woitaschek
05/28/2018, 7:30 PMAsyncTask.THREAD_POOL_EXECUTORi
igorvd
05/28/2018, 8:11 PMI'm considering using it too. But my unit tests are now failing because of the android framework dependency
a
alex.krupa
05/28/2018, 8:27 PM@igorvd pass your dispatcher through the constructor so that you can easily replace it with a non-Android one in unit tests.
Another solution (that may be considered not clean) would be to make the top-level property from @louiscad's suggestion a
varp
Paul Woitaschek
05/28/2018, 8:27 PMI always inject the dispatchcer
i
igorvd
05/28/2018, 8:31 PMYeah I sugest it on the project start, but my manager tought that it would not be necessary...
For now I just put it in a try-catch, and use the CommonPool in case the asyncTask is not available. At least the tests are working...
But I'll definitely refactor to inject the dispatcher eventually
d
dave08
05/29/2018, 1:59 AMMaybe a top level val with an if on BuildConfig might be better than try catch?
dave08
05/29/2018, 1:59 AMBut injection is probably best...
i
igorvd
05/29/2018, 11:44 AMwhat should I test on buildConfig? I don't want to test for debug builds to choose the dispatcher, for example
d
dave08
05/29/2018, 12:17 PM5 Views