Hi! I have a non suspending function that has a callback where errors are received, and I want any i...

# coroutines

[louiscad]

Hi!
I have a non suspending function that has a callback where errors are received, and I want any incoming error to stop the coroutine it may have been launched in.
My code currently looks like this:
1️⃣

fun SomeReceiver.someFunction(parentJob: Job) {
    someNonSuspendingCode()
    setOnErrorListener { errorCode ->
        parentJob.cancel(SomeException(errorCode))
    }
}

I'm wondering if I should make it a suspend fun so I can get the current job from the coroutineContext (currently available in the intrisics package) and remove this not so nice (IMHO) parentJob parameter.
If I did, it'd look like this:
2️⃣

suspend fun SomeReceiver.someFunction() {
    val currentJob = coroutineContext[Job]!!
    someNonSuspendingCode()
    setOnErrorListener { errorCode ->
        currentJob.cancel(SomeException(errorCode))
    }
}

[elizarov]

I’d go with suspend fun