Hey guys can we improve this piece of code ```val filteredTo

Question

Hey guys can we improve this piece of code ```val filteredTopics by lazy MutableStateFlow lt List lt Topics gt gt emptyList ``` ```val temp = list filter it topics = null filter it title == value title filteredTopics value = temp firstOrNull topics sortedBy topic gt topic title emptyList ```

Diego Marzo · Answer

Hi Vivek I believe that a small improvement could be to do both filters together the are pretty small ```filteredTopics value = list filter it topics = null amp amp it title == value title firstOrNull topics sortedBy topic gt topic title emptyList ```

Diego Marzo · Answer

I would and this is 100 personal taste do it together just with returns and nice spacing

Vivek Modi · Answer

Hi < Diego Marzo> thank you so much

ephemient · Answer

` filter firstOrNull ` == ` firstOrNull ` ` emptyList ` == ` orEmpty `

Vivek Modi · Answer

< ephemient> Sorry I didn t understand correctly Can you please explain me what will go inside first `filter` and you comparing `==` so what will be come there and how it will `sort` my list as well

Diego Marzo · Answer

```filteredTopics value = list firstOrNull it topics = null amp amp it title == value title ```

Diego Marzo · Answer

You can simply drop filter

Diego Marzo · Answer

since firstOrNull will do the filtering

Vivek Modi · Answer

and == `whatwillcomehere` firstOrNull

Diego Marzo · Answer

And orEmpty that I didn t know about smile is nice sugar to use instead of emptyList

Diego Marzo · Answer

```filteredTopics value = list firstOrNull it topics = null amp amp it title == value title orEmpty lt lt lt THIS IS WRONG should be like ephemient mentioned bellow filteredTopics value = list firstOrNull it topics = null amp amp it title == value title topics sortedBy it title orEmpty ```

Diego Marzo · Answer

This you should be able to use just that instead

Vivek Modi · Answer

Okk I ll try that

Vivek Modi · Answer

Thank you so much

Diego Marzo · Answer

I learnt something new as well

ephemient · Answer

the == have equivalent results to match the original snippet it would look like ```filteredTopics value = list firstOrNull it topics = null amp amp it title == value title topics sortedBy it title orEmpty ```

Vivek Modi · Answer

nice < ephemient> thank you so much It really help me

Vivek Modi · Answer

Thank you once again < Diego Marzo>

Paul Woitaschek · Answer

Why is that stateflow wrapped in a lazy

Vivek Modi · Answer

for lazy initialized Is there any problem in that

Paul Woitaschek · Answer

Why do you do that

Paul Woitaschek · Answer

If there is not more to it it s just another additional allocation of the lazy and only makes the code a little bit more complex

ephemient · Answer

lazy has cost additional boxing lambda creation reflection data synchronization

ephemient · Answer

Chet and Romain go into this <https youtu be ULgEn3 pzzs t=932>

Vivek Modi · Answer

Okk I ll remove that