Does anyone have any tips as to how I can improve ...

# codereview

[therealbluepandabear]

Does anyone have any tips as to how I can improve this code? Something about it seems messy but I can't pinpoint what it is.

I created my own FileHelperUtilities class in Kotlin to help with:

• Saving a Bitmap as PNG/JPG
• Opening an image from a URI with an Intent
Code:

bject FileHelperUtilities {
    fun saveBitmapAsImage(compressionOutputQuality: Int, compressionFormat: Bitmap.CompressFormat, onTaskFinished: (OutputCode, File) -> Unit, context: Context) {
        // Thanks to <https://stackoverflow.com/users/3571603/javatar> on StackOverflow - quite a bit of the code is based off of their solution

        var outputCode = OutputCode.SUCCESS
        val pathData = "image/jpeg"
        val outputName = if (compressionFormat == Bitmap.CompressFormat.PNG) "$projectTitle.png" else "$projectTitle.jpg"

        val environmentRoot = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DCIM).toString()
        val directory = File(environmentRoot)

        directory.mkdirs()

        val file = File(directory, outputName)

        try {
            val outputStream = FileOutputStream(file)
            val bitmapToCompress =  outerCanvasInstance.fragmentHost.drawToBitmap()
            bitmapToCompress.compress(compressionFormat, compressionOutputQuality, outputStream)
            outputStream.close()
        } catch (exception: Exception) {
            outputCode = OutputCode.FAILURE
        } finally {
            onTaskFinished(outputCode, file)
        }

        MediaScannerConnection.scanFile(context, arrayOf(file.path), arrayOf(pathData), null)
    }

    fun openImageFromUri(uri: Uri, onTaskFinished: (OutputCode) -> Unit, context: Context) {
        var outputCode = OutputCode.SUCCESS
        val intentAction = Intent.ACTION_VIEW
        val type = "image/*"

        val intent = Intent()
        intent.action = intentAction
        intent.setDataAndType(uri, type)

        try {
            context.startActivity(intent)
        } catch (exception: Exception) {
            outputCode = OutputCode.FAILURE
        } finally {
            onTaskFinished(outputCode)
        }
    }
}

Here it is in use:

package com.realtomjoney.pyxlmoose.customviews.pixelgridview

import android.graphics.Bitmap
import android.net.Uri
import com.realtomjoney.pyxlmoose.activities.canvas.projectTitle
import com.realtomjoney.pyxlmoose.enums.OutputCode
import com.realtomjoney.pyxlmoose.extensions.SnackbarDuration
import com.realtomjoney.pyxlmoose.extensions.showSnackbar
import com.realtomjoney.pyxlmoose.extensions.showSnackbarWithAction
import com.realtomjoney.pyxlmoose.utility.FileHelperUtilities
import java.io.File

lateinit var file: File

fun PixelGridView.extendedSaveAsPNG() {
   FileHelperUtilities.saveBitmapAsImage(90, Bitmap.CompressFormat.PNG, { outputCode, _file ->
       if (outputCode == OutputCode.SUCCESS) {
           file = _file

           showSnackbarWithAction("Successfully saved $projectTitle as PNG", SnackbarDuration.MEDIUM, "View") {
               FileHelperUtilities.openImageFromUri(Uri.fromFile(file), { outputCode ->
                   if (outputCode == OutputCode.FAILURE) {
                       showSnackbar("Error trying to view file", SnackbarDuration.DEFAULT)
                   }
               }, context)
           }
       } else {
           showSnackbar("Error saving $projectTitle as PNG", SnackbarDuration.DEFAULT)
       }
    }, context)
}

[Paul Griffith]

I would probably (just as a style convention) put the lambda parameter last, and move Context to be the first parameter or possible a context receiver (I don't do Android, so I don't know what it's really needed/used for)

[therealbluepandabear]

Thanks for the feedback 🙂