Hey guys ```var millis = 123L var i = 0 buildList lt Pair lt

Question

Hey guys ```var millis = 123L var i = 0 buildList lt Pair lt TimeUnit Long gt gt add Year to millis MillisInYear millis = get i++ second MillisInYear add Month to millis MillisInMonth millis = get i++ second MillisInMonth add Day to millis MillisInDay millis = get i++ second MillisInDay add Hour to millis MillisInHour millis = get i++ second MillisInHour add Minute to millis MillisInMinute millis = get i++ second MillisInMinute add Second to millis 1 000 millis = get i++ second 1 000 add Millisecond to millis ``` This code is used to make a timer counter picture However it s very ugly as it is How can I enhance this

Joffrey · Answer

You can probably use the duration API for this to avoid manual calculations

LeoColman · Answer

Do you have any pointer on how this could be done with duration I tried but still had to make manual conversions

LeoColman · Answer

manual calculations rather

bezrukov · Answer

I think Duration api won t help with months years because months are different as well as years but for days hours you can use toComponents ```123 milliseconds toComponents days hours minutes seconds nanoseconds gt ```

rook · Answer

```listOf Year Month Day Hour Minute Second Millisecond forEach val unitsInTotal = millis it millis add it to unitsInTotal millis = unitsInTotal it millis ```

Daniel · Answer

Best don t mix responsibilities First calculate the individual parts and then create a list from it When the content of the list is fixed which seems to be the case from years to milliseconds you don t even need a list Best create a class which contains the individual parts

Joffrey · Answer

< Daniel> I beg to differ here If all elements are treated the same way as a collection there is no reason to enumerate them in many places in code such as in properties of a class It s best to treat them as a collection to avoid repeating code everywhere Typically here you would be repeating the calls to the calculation the list of properties of the class the usage of these properties in the UI code and any other usage of those fields If later you want to add one new unit such as nanos you would also need to update all of those places

jimn · Answer

you should be able to do without looking at the docs here `listOf duration days to duration =it asDays duration hours to duration =it asHours ` and so on to reduce a duration and leave the remainders for further reduction