Which one? 1. ```class SnackbarUtils { companion object { fun makeSnackbar() { ...

# codereview

[therealbluepandabear]

Which one?

1.

class SnackbarUtils {
    companion object {
        fun makeSnackbar() {

        }
    }
}

2.

class SnackbarUtils {
    fun makeSnackbar() {

    }
    companion object {
        val instance get() = SnackbarUtils()
    }
}

3.

class SnackbarUtils {
    fun makeSnackbar() {

    }
    companion object {
        val instance = SnackbarUtils()
    }
}

[Javier]

no one for me

[therealbluepandabear]

What would you use then?

[Javier]

fun Activity.makeSnackbar(...) or something so, no class, no object

[therealbluepandabear]

Yeah but that can clutter activity code 😕

[therealbluepandabear]

My current activity has 250 lines

[Javier]

it is a extension function

[therealbluepandabear]

Oh true...

[therealbluepandabear]

Make sense

[Javier]

you can put it wherever you want

[therealbluepandabear]

Isn't MVVM a better choice than just extension functions?

[Javier]

i.e. SnackbarExtensions.kt

[Javier]

this is not related to the architecture

[therealbluepandabear]

Hm ok

[Javier]

just UI showing UI

[therealbluepandabear]

So I shouldn't make a new class for it? Is it bad if I do?

[therealbluepandabear]

Is it valid, or?

[Javier]

it is not wrong but I dont see any advantage of doing that instead of using an extension func

[therealbluepandabear]

Ok

[Javier]

well

[Javier]

if it is an extension function

[Javier]

you can only use it in the right places

[Javier]

if it is a class

[Javier]

you can use wherever you want

[therealbluepandabear]

If I want to use a certain snackbar style app wide isn't it bad if it's confined to a certain activity?

[Javier]

don't have a lot of sense instantiating a class about snackbars in the viewmodel for example

[therealbluepandabear]

Cause I'm using the snackbar in multiple activities

[Javier]

extension function of a generic activity, not specific one

[Javier]

or a Fragment.

[therealbluepandabear]

Oh nice! Never knew you could do taht

[therealbluepandabear]

that*

[Javier]

so you can use it in all activities or fragments

[therealbluepandabear]

Gotcha... I will work on it

[therealbluepandabear]

hey I have a question

[therealbluepandabear]

It's saying that 'Activity.' is redundant

[Javier]

code

[therealbluepandabear]

So instead of:

package com.realtomjoney.pyxlmoose

import android.app.Activity
import android.graphics.Color
import android.view.View
import com.google.android.material.snackbar.Snackbar

const val snackbarBackgroundTint: String = "#eaddff"

fun Activity.showSnackbar(contextView: View, snackbarText: String, duration: Int) {
    Snackbar.make(contextView, snackbarText, duration)
            .setTextColor(Color.BLACK)
            .setBackgroundTint(Color.parseColor(snackbarBackgroundTint))
            .show()
}

[therealbluepandabear]

it wants:

package com.realtomjoney.pyxlmoose

import android.app.Activity
import android.graphics.Color
import android.view.View
import com.google.android.material.snackbar.Snackbar

const val snackbarBackgroundTint: String = "#eaddff"

fun showSnackbar(contextView: View, snackbarText: String, duration: Int) {
    Snackbar.make(contextView, snackbarText, duration)
            .setTextColor(Color.BLACK)
            .setBackgroundTint(Color.parseColor(snackbarBackgroundTint))
            .show()
}

[Javier]

you are not passing the activity there

[therealbluepandabear]

Oh can you teach me how to do it bro

[Javier]

fun View.showSnackbar(snackbarText: String, duration: Int) {
    Snackbar.make(this, snackbarText, duration)
            .setTextColor(Color.BLACK)
            .setBackgroundTint(Color.parseColor(snackbarBackgroundTint))
            .show()
}

[therealbluepandabear]

Ohh...

[Javier]

so you do someView.showsnackbar(..)

[therealbluepandabear]

Thanks for this 😄

[Matteo Mirk]

Extensions and Activity apart, if I were to write a singleton utility I wouldn’t use any of the above, just:

object SnackbarUtils {
    fun makeSnackbar() {
    }
}

[Colton Idle]

Yeah, I think I'd go extension function as well, but I do sometimes worry (too much) about polluting a specific type with too many extensions.