any better way than duplicate code like this? (I'm receive a json response in 1 line, I want to loop...

# codereview

[elect]

any better way than duplicate code like this? (I'm receive a json response in 1 line, I want to loop char by char to properly display it for debug with the right new lines and indentations)

var c = it.read() // it: InputStream
        while (c != -1) {
            ..
            c = it.read()
        }

[elect]

while(true){
  val c = it.read()
  if(c == -1) break
  ..
}

[elect]

I still miss the java way, though 😐

[ephemient]

https://youtrack.jetbrains.com/issue/KT-25698

[ephemient]

another alternative:

generateSequence { it.read() }.takeWhile { it != -1 }.forEach { c ->
    // ...
}

[elect]

thanks for bringing that up, but it has already my vote 🙂
Interesting alternative, thanks

[Michael Böiers]

Nice! Makes sense as an extension function.

import java.io.ByteArrayInputStream
import java.io.InputStream

fun InputStream.asCharSequence() = generateSequence { read() }
    .takeWhile { it != -1 }
    .map { it.toChar() }

val a = ByteArrayInputStream("foo".toByteArray())

a.asCharSequence().forEach { c -> println(c) }

[Michael Böiers]

(wrap with a Reader first if character conversion can be an issue)

[ephemient]

you're not doing any character (en|de)coding there so I think a CharSequence is misleading...

[ephemient]

InputStream.asByteSequence() and Reader.asCharSequence() would be better

[Michael Böiers]

Yes, hence my comment after I had posted the code.

[Michael Böiers]

I wonder whether there‘s something in NIO which would do this out of the box ...

[ephemient]

(byte|char)-at-a-time is not a great way to work with files and NIO doesn't really support it (APIs are geared towards reading/writing buffers)

[Michael Böiers]

Of course there are better ways to do it. If it’s a small file I would read it into a String and process it from there. If it’s about the indentation, going line by line with a BufferedReader would also be an option. Ultimately I would question Giuseppe’s requirement of being able to reproduce the exact formatting of the JSON. Either use a proper JSON parser to extract the contents, or don’t look at the content at all and just pass it on.