is there a better way to write this `users = listOf klaus se kotlinlang #codereview

Channels

lincheck

kobweb

koalaql

kotlin-multiplatform-contest

osgi

brikk

revolver

tricity-kotlin-user-group

cincinnati-user-group

prozis-android-backup

refactoring-to-kotlin

russian-kotlinasfirst

androidgithubprojects

navigation-architecture-component

stayhungrystayfoolish

practical-functional-programming

tensorflow

swagger-gradle-codegen

kotlinultimatechallenge

competitive-programming

skia-wasm-interop-temp

java-to-kotlin-refactoring

event21-community-content

myndocs-oauth2-server

jvm-ir-backend-feedback

Title

christophsturm

03/31/2021, 2:24 PM

is there a better way to write this? :

users = listOf("klaus", "sepperl")+if (addChris) listOf("chris") else listOf()

Luke

03/31/2021, 2:30 PM

You can use `buildList`:

users = buildList {
    addAll("klaus", "sepperl")
    if (addChris) add("chris")
}

christophsturm

03/31/2021, 2:37 PM

thanks! thats more performant for sure. but also a bit verbose

Zach Klippenstein (he/him) [MOD]

03/31/2021, 3:08 PM

Is it?

else listOf()

is pretty verbose too. And i think it’s dangerous to try to minimize “verbosity”. It’s much more important to maximize readability, and sometimes going too far down the verbosity route can make code harder to read. The

buildList

code is extremely readable imo. There’s zero code there that doesn’t express something relevant about what it’s doing.

christophsturm

03/31/2021, 3:17 PM

its way better than my version for sure.

for some reason i would just prefer

users= buildList("klaus", "sepperl") { if (addChris) add("chris") }

@Zach Klippenstein (he/him) [MOD] btw, “also a bit verbose” meant “also like the original example”

Luke

03/31/2021, 5:24 PM

Well... You could also do:

users = mutableListOf("klaus", "sepperl").apply {
    if (addChris) add("chris")
} // .toList() if you want a read-only list

ilya.gorbunov

04/01/2021, 4:15 PM

listOfNotNull("klaus", "sepperl", "chris".takeIf { addChris})

👍 1

🎉 1

christophsturm

04/01/2021, 4:16 PM

thats pretty cool

4 Views

#codereview Join Slack