in this code is there a way to avoid creating IdHandler twic kotlinlang #codereview

Channels

kotlin-foundation

compose-android

ohio-kotlin-users

kotlin-by-example

sofl-user-group

kotlin-multiplatform-contest

tricity-kotlin-user-group

kotlin-in-action

android-databinding

cincinnati-user-group

fluid-libraries

codemash-precompiler

kotlingforbeginners

jhipster-kotlin

prozis-android-backup

realworldkotlin

graviton-browser

spring-security

domain-driven-design

connect-audit-events

swiss-user-group

effectivekotlin

refactoring-to-kotlin

russian-kotlinasfirst

androidgithubprojects

introduce-yourself

pocketgitclient

effective-kotlin

algolialibraries

lambdaworld_cadiz

intellij-tricks

kotlin-pakistan

navigation-architecture-component

strife-discord-lib

machinelearningbawas

leedskotlinusergroup

stayhungrystayfoolish

kotest-contributors

practical-functional-programming

swagger-gradle-codegen

100daysofkotlin

kotlinultimatechallenge

pattern-matching

kotlinforbeginners

competitive-programming

compose-ui-showcase

competitivecoding

kotlin-data-storage

skia-wasm-interop-temp

java-to-kotlin-refactoring

event21-community-content

androidx-xprocessing

embedded-kotlin

fb-internal-demo

image-processing

myndocs-oauth2-server

kotlintest-devs

beepiz-libraries

kotlinprogrammers

cscenter-course-2016

k2-early-adopters

intellij-plugins

language-proposals

library-development

refreshversions

language-evolution

kotlinx-datetime

framework-elide

compose-desktop

jvm-ir-backend-feedback

android-architecture

100daysofkotlin-2021

github-workflows-kt

python-contributors

squarelibraries

arrow-contributors

codingconventions

getting-started

Title

c

christophsturm

03/10/2021, 1:44 PM

in this code, is there a way to avoid creating IdHandler twice?

internal data class EntityInfo<T:Any>(val idHandler: IDHandler, val classInfo: ClassInfo<T>) {
    constructor(kClass: KClass<T>) : this(Table(kClass), IDHandler(kClass), ClassInfo(kClass, IDHandler(kClass)))
}

i guess its not possible because the primary constructor call has to be the first instruction of the secondary constructor so I cannot extract a variable for IdHandler(kClass)

s

Shawn

03/10/2021, 2:58 PM

you’re probably better off with a factory function in the companion object tbh

c

christophsturm

03/10/2021, 3:37 PM

or a top level method named like a constructor

fun <T:Any>EntityInfo(kClass: KClass<T>): EntityInfo<T> {
    val idHandler = IDHandler(kClass)
    return EntityInfo(Table(kClass), idHandler, ClassInfo(kClass, idHandler))
}
internal data class EntityInfo<T:Any>(val table:Table, val idHandler: IDHandler<T>, val classInfo: ClassInfo<T>)

4 Views

#codereview Join Slack