Untitled

# codereview

[SomeCat]

Untitled

Untitled

[Matteo Mirk]

the return statement will throw NPE if key is null, maybe you want to handle it differently?

[SomeCat]

I think the log error call throws already and exits.

[SomeCat]

But you are probably correct, I should throw an exception instead.

[Matteo Mirk]

No, the log error doesn’t throw because you’re not dereferencing key , even better without safe call operators it won’t even compile. Anyway, after the initial check on the file you shouldn’t continue the execution: it’s useless to the logic you want. Instead you should either return early with some meaningful value (null or Result ), or you should throw in each case. Don’t log and throw, do either but not both.

[SomeCat]

Yeah, I got two good responses on SO that went the same path.
The more interesting aspect is that I now get to the impression that just having such code in gradle is already a smell. That API key should rather come out of a provider, or maybe some properties file.

[Matteo Mirk]

Oh is it a Gradle task? Yes, maybe try to see if there’s a built-in mechanism to do that.

[SomeCat]

Yeah, we figured that we definitely need our users to have a local gradle.properties for some things we cant do in code. With that requirement, we just told them to have all relevant information in that file. So we can just pull from there, without all the extra effort