``` if ocrItem pattern is DateRegex ocrItem newValue = resul kotlinlang #codereview

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

i

ivano

01/09/2020, 8:00 AM

if (ocrItem.pattern is DateRegex) {
                        ocrItem.newValue = result.transformToDefaultDate()
                    } else {
                        ocrItem.newValue = result
                    }

a

adamd

01/09/2020, 9:13 AM

ocrItem.newValue = result.let { if ocrItem.pattern is DateRegex it.transformToDefaultDate() else it }

I'm not sure if it is more readable after all but looks better to me

m

Matteo Mirk

01/09/2020, 9:47 AM

apart from readability, there’s a deeper design problem: you’re operating outside the object in an explicit way, against the “tell, don’t ask” principle (https://www.martinfowler.com/bliki/TellDontAsk.html): you’re asking the object for data and perform some logic outside instead of just telling it to do it for you. Following the principle your code should be something like:

ocrItem.setResult(result)

// then, inside OcrItem class:
fun setResult(result: Result) {
    newValue = if (pattern is DateRegex) {             
        result.transformToDefaultDate()
    } else {
        result
    }       
}

(i made some things up as I don’t know the actual types you’re using)

💯 1

👍 2

Also, there’s nothing wrong or “javish” in using a good old if/else in Kotlin: most of the time makes the code way more readable than let/apply/also/?:

👍 1

i

ivano

01/09/2020, 11:03 AM

thank you very much

👍 1

2 Views

#codereview Join Slack