Hi guys. I have two functions here, not sure if it can be more simplify. ``` findViewById<Button...

# codereview

[Ayden]

Hi guys.
I have two functions here, not sure if it can be more simplify.

findViewById<Button>(R.id.test).setOnClickListener(View.OnClickListener {
    if (progressBar.visibility == View.VISIBLE) {
        showProgressBar(false)
    } else {
        showProgressBar(true)
    }
})

fun showProgressBar(visibility: Boolean) {
    progressBar.visibility = if (visibility) {
        View.INVISIBLE
    } else {
        View.VISIBLE
    }
}

[Khan]

For first one you can simply do it like this:

val shouldShow = progressBar.visibility != View.VISIBLE
showProgressBar(shouldShow)

[Khan]

fun showProgressBar(shouldShow: Boolean) {
    progressBar.visibility = if (shouldShow) View.VISIBLE else View.INVISIBLE
}

I would do it like this & without braces for if else, also in single line. it will look more cleaner

[Ayden]

I see. Thanks @Khan

[rkeazor]

setOnClickListener { if ... } you dont need the explicit View.OnClickListener

[Aslam Hossin]

Observe `LiveData` and show progress. More or less my idea is like below snippet.

[yousefa2]

You can use isVisible Extension and it can simply be

progressBar.isVisible = !progressBar.isVisible