Hello, I have a java function with following signature: `public static ScoreDto score(String email, ...

# codereview

[Milan Hruban]

Hello, I have a java function with following signature:
public static ScoreDto score(String email, String name, String surname, Function<String, Boolean> function)
What would be the idiomatic/more readable approach to call it from Kotlin, given that dataProvider is a nullable instance of class that implements Function<String, Boolean>?

score(
        "<mailto:[e-mail]|[e-mail]>",
        "John",
        "Doe"
    ) { dataProvider?.apply(it) }

vs

score(
        "<mailto:[e-mail]|[e-mail]>",
        "John",
        "Doe",
        { dataProvider?.apply(it) }
     )

vs

dataProvider?.let {
    score(
       "<mailto:[e-mail]|[e-mail]>"
        "John",
        "Doe",
        it
    )
}

[SiebelsTim]

The last one has different semantics than the first two. It doesn't call the function if the provider is null.
The first is more idiomatic than the second I'd say.

[Milan Hruban]

oh I didn't even realize that. Thank you

[Matteo Mirk]

The first form is definitely the most idiomatic. — side note: the last parameter in the Java signature could be simplified to Predicate<String> function.