This is probably not ideal… open to any feedback `...

# codereview

[tenprint]

This is probably not ideal… open to any feedback

sharedElements?.let { thisSharedElements -> 
  names?.let { thisNames ->
    viewHolder?.let { thisViewHolder ->
      thisSharedElements[thisNames[0]] = thisViewHolder.itemView
    }
  }
}

[Pavlo Liapota]

Why not just this?

if (sharedElements != null
		&& names != null
		&& viewHolder != null) {
    sharedElements[names[0]] = viewHolder.itemView
}

If you do this often, then I would recommend to add extension function to your sharedElements to hide this code and call it like this:

sharedElements?.setElement(names, viewHolder)

It depends on details of your real usages.

[tenprint]

Thanks

Why not just this?

These are “platform” types in Android, so they are not val. I can do that, but would need to assign them all to `val`s first

[tenprint]

so using the nested ?.let {...} would be fewer lines of code

[tenprint]

but ugly 🙂

[Pavlo Liapota]

I see… but it is more important for code to be readable than short 🙂

[tenprint]

good point 👍

[tenprint]

thanks for your feedback!

[ursus]

yea dont do that