This is more of Android specific. I need a reference to dialog for further handling. "with" or "run"...

# codereview

[Sam]

This is more of Android specific. I need a reference to dialog for further handling. "with" or "run"?

dialog = with( AlertDialog.Builder( this ) ) {
        setTitle( "foo" )
        setMessage( "bar" )
        setCancelable(true)
        create()
    }.also {
        it.show()
    }

    or

    dialog = AlertDialog.Builder( this ).run {
        setTitle( "foo" )
        setMessage( "bar" )
        setCancelable(true)
        create()
    }.also {
        it.show()
    }

[dalexander]

I like with slightly more but I don’t have a strong opinion

[Sam]

I started of using run but now prefer with

[apoorv9990]

I usually like apply when I am initializing something and setting things up

val dialog = AlertDialog.Builder(this).apply {
      setTitle( "foo" )
      setMessage( "bar" )
      setCancelable(true)
    }.show()

[Sam]

Looks good, but apply returns the Builder and not the dialog itself and that rules out apply, also on builder

[apoorv9990]

But show() gives you the dialog?

[Sam]

Nope, show returns void

[Sam]

I guess, you missed the create(). Create on builder returns the dialog

[Sam]

So it basically boils down to with, run or let

[Vladyslav Sitalo]

but with either of those you don’t need to do also at the end, you can just do .show directly

[apoorv9990]

The show() I have used in my code is `AlertDialog.Builder`’s show(), since apply will return the Builder, which does return the AlertDialog

[Sam]

isn't the last statement considered the return value? create() returns the dialog and show() is a member of the dialog and returns nothing (it just dispatches request to show the dialog)

[Sam]

Gotcha, i missed the show on the builder

[Sam]

with that, it looks more readable

[Andreas Sinz]

you could do

val dialog = AlertDialog.Builder(this).apply {
      setTitle( "foo" )
      setMessage( "bar" )
      setCancelable(true)
    }.create()
    .show()

[hudsonb]

why not just use method chaining? I dont think readability is being improved at all here

[Sam]

Suggestion from @apoorv9990 does it. It leverages a method on the builder which creates the object and requests a UI show as well

[oday]

I don’t think you should spend time thinking of a solution because there is no problem here, just chain dotcalls as we always have

[oday]

it’s only going to be something clever that the next person has to understand before they continue reading

[anstaendig]

This does not provide anything really, does it? It’s already a builder in itself