https://kotlinlang.org logo
#codereview
Title
# codereview
d

Daniel Tam

09/19/2018, 5:44 AM
It's hard to give an answer without getting more context in this situation
s

Sudhir Singh Khanger

09/19/2018, 7:10 AM
https://github.com/sudhirkhanger/Genius Anything specific you want to know?
d

Daniel Tam

09/19/2018, 1:58 PM
by context I just mean specifically what you're trying to do here. E.g. whether you intend for movieList to stay the same, or to change.
It looks like movieRepository.getMovies() is some sort of API call and it could possibly return a different lists every time. Doing
val movieList = movieRepository.getMovies()
will cache the result so I'm not sure that's necessarily what you want
7 Views