``` if player1List containsAll listOf 1 3 7 || player1List c

Question

``` if player1List containsAll listOf 1 3 7 || player1List containsAll listOf 1 3 9 || player1List containsAll listOf 1 7 9 || player1List containsAll listOf 1 3 8 cell = 5 else if player1List containsAll listOf 1 3 4 cell = 2 else if player1List containsAll listOf 1 5 7 cell = 3 else if player1List containsAll listOf 1 3 5 || player1List containsAll listOf 1 2 4 cell = 7 else if player1List containsAll listOf 3 5 9 cell = 1 ```

Andreas Sinz · Answer

you could create a `List lt Pair lt List lt List lt int gt gt int gt gt ` `first` is your list of condition lists and `second` is the cell value then you can do something like `cell = map firstOrNull pair gt pair first all player1List containsAll it second`

leosan · Answer

also I m not 100 but I think when you do `listOf 1 2 3 ` you are creating a new object every time you check the condition

edwardwongtl · Answer

< leosan> You re correct

Ayden · Answer

Would you mind to tell me what is this mean

Ayden · Answer

`List lt Pair lt List lt List lt int gt gt int gt gt `

edwardwongtl · Answer

Should better be `Map lt List lt Int gt Int gt `

Ayden · Answer

< edwardwongtl> is that something like create Set of set

gaetan · Answer

If I had to keep the same structure of code I would encapsulate it to make it more readable I would also break the code convention to simplify the reading using horizontal alignment ``` if p1 hasPlayed 1 3 7 || p1 hasPlayed 1 3 9 || p1 hasPlayed 1 7 9 || p1 hasPlayed 1 3 8 cell = 5 else if p1 hasPlayed 1 3 5 || p1 hasPlayed 1 2 4 cell = 7 else if p1 hasPlayed 1 3 4 cell = 2 else if p1 hasPlayed 1 5 7 cell = 3 else if p1 hasPlayed 3 5 9 cell = 1 ```

edwardwongtl · Answer

You can lift the assignment of `cell` outside also replace all those `if else if` with `when`

gaetan · Answer

Yes it s more readable ``` when p1 hasPlayed 1 3 7 || p1 hasPlayed 1 3 9 || p1 hasPlayed 1 7 9 || p1 hasPlayed 1 3 8 gt cell = 5 p1 hasPlayed 1 3 5 || p1 hasPlayed 1 2 4 gt cell = 7 p1 hasPlayed 1 3 4 gt cell = 2 p1 hasPlayed 1 5 7 gt cell = 3 p1 hasPlayed 3 5 9 gt cell = 1 ```

edwardwongtl · Answer

Even better ``` cell = when p1 hasPlayed 1 3 7 || p1 hasPlayed 1 3 9 || p1 hasPlayed 1 7 9 || p1 hasPlayed 1 3 8 gt 5 p1 hasPlayed 1 3 5 || p1 hasPlayed 1 2 4 gt 7 p1 hasPlayed 1 3 4 gt 2 p1 hasPlayed 1 5 7 gt 3 p1 hasPlayed 3 5 9 gt 1 else gt some default value ```

gaetan · Answer

It s not the same code you should have a default branch

edwardwongtl · Answer

ya you re right just added

gaetan · Answer

Your code is now ok but it s not doing the same logic as the beginning

gaetan · Answer

can we set a default value I don t know

Ayden · Answer

This is the code of doing Tic Tac Toe

Ayden · Answer

I think last time they suggest me to do a set of set

Ayden · Answer

I am looking for a way to optimize the code disappointed

edwardwongtl · Answer

A default value of `0` seems to be a nice choice

edwardwongtl · Answer

Since you re indicating the valid cells by `1 9`

Ayden · Answer

Ya Whenever the cell = 0

Ayden · Answer

Then it will keep looping

edwardwongtl · Answer

I think I found a better way then set of set

edwardwongtl · Answer

``` data class Condition val pos1 Int val pos2 Int val pos3 Int val value Int val conditions = listOf Condition 1 3 7 5 Condition 1 3 9 5 Condition 1 7 9 5 Condition 1 3 8 5 Condition 1 3 4 2 Condition 1 5 7 3 Condition 1 3 5 7 Condition 1 2 4 7 Condition 3 5 9 1 val player1List = listOf 1 2 4 val cell = conditions firstOrNull pos1 pos2 pos3 gt player1List contains pos1 and player1List contains pos2 and player1List contains pos3 value 0 ```

Andreas Sinz · Answer

IMO a default value which is in the same space as the valid cells is wrong If you use `null` the compiler enforces that you check whether its a valid cell

edwardwongtl · Answer

We didn t set the default value to the same space as the valid cells

Andreas Sinz · Answer

`0` is an ordinary integer just like `1` or `9` and can be mistaken for a valid cell if you forget to check `cell = 0`

benleggiero · Answer

My recommendation ``` cell = when player1List containsAll listOf 1 3 7 || player1List containsAll listOf 1 3 9 || player1List containsAll listOf 1 7 9 || player1List containsAll listOf 1 3 8 gt 5 player1List containsAll listOf 1 3 4 gt 2 player1List containsAll listOf 1 5 7 gt 3 player1List containsAll listOf 1 3 5 || player1List containsAll listOf 1 2 4 gt 7 player1List containsAll listOf 3 5 9 gt 1 else gt defaultValue ```

edwardwongtl · Answer

< Andreas Sinz> He said the function will loop when `cell == 0` before though

Ayden · Answer

Thanks everyone for giving me suggestion Much appreciated

Ayden · Answer

Thanks again heart

Ayden · Answer

< edwardwongtl> would you mind to tell me why you need to create a data class

edwardwongtl · Answer

< Ayden> Its more light weight then a set of set IMO

andyb · Answer

< edwardwongtl> It s not more lightweight than just a standard ```class Condition ``` though

edwardwongtl · Answer

< andyb> You re right but using a `data class` allows you to use the destructing syntax