<@U5R5FGVH7> any feedback to provide ? I’m aiming ...
# vertx
j
@napperley any feedback to provide ? I’m aiming to merge this into master this week
n
There is an issue with iterating over messages in a channel. In the testUnregister test (https://github.com/napperley/vertx-coroutines/blob/3d2632b8daccaddc726a2a5aa063888d4d9da05a/src/test/kotlin/org/digieng/vertxcoroutines/EventBusTest.kt#L49) it ends up in an infinite loop until the test times out.
Noticed in the example that the asyncEvent function is being used to delay a Coroutine, which wouldn't be obvious to a first time user. Would be clearer if the delay function from kotlinx.coroutines (https://github.com/Kotlin/kotlinx.coroutines/blob/dea9bd6a426fe5bdc1c9bd8a429d22296eb27728/integration/kotlinx-coroutines-jdk8/src/test/kotlin/examples/CancelFuture-example.kt#L26) was used instead.
j