Source ```class MyPublishedAdvertisementsViewModel private val advertisementRepository AdvertisementRepository ViewModel var myPublishedAdvertisements MutableLiveData lt NetworkCall lt MyPublishedAdvertisementsResponse gt gt = MutableLiveData val myPublishedAdvertisements LiveData lt NetworkCall lt MyPublishedAdvertisementsResponse gt gt = myPublishedAdvertisements Called every time our UI is onStarted fun getFreshData myPublishedAdvertisements value = liveData emit NetworkCall lt MyPublishedAdvertisementsResponse gt NetworkStatus LOADING null val publishedAdvertisements = advertisementRepository getMyPublishedAdvertisements emit publishedAdvertisements ```

It is a wrapper data class to be used for all my network responses this is the code ```data class NetworkCall lt out T gt val status NetworkStatus val data T val message String companion object fun lt T gt success data T NetworkCall lt T gt return NetworkCall NetworkStatus SUCCESS data null fun lt T gt error msg String data T NetworkCall lt T gt return NetworkCall NetworkStatus ERROR data msg fun lt T gt loading data T NetworkCall lt T gt return NetworkCall NetworkStatus LOADING data null ```

I am not sure what I am doing wrong thinking face

Source ```class MyPublishedAdvertisementsViewModel private v kotlinlang #android-architecture

Channels

stayhungrystayfoolish

skia-wasm-interop-temp

java-to-kotlin-refactoring

event21-community-content

refactoring-to-kotlin

kotlin-multiplatform-contest

tricity-kotlin-user-group

cincinnati-user-group

prozis-android-backup

russian-kotlinasfirst

juul-libraries

lanark

wimix_sentry

androidgithubprojects

swagger-gradle-codegen

competitive-programming

navigation-architecture-component

myndocs-oauth2-server

practical-functional-programming

hyderabad

kotlinultimatechallenge

jvm-ir-backend-feedback

#android-architecture

Title

Ofir Bar

03/11/2020, 11:22 AM

Source:

Copy code

class MyPublishedAdvertisementsViewModel(private val advertisementRepository : AdvertisementRepository) : ViewModel(){

    var _myPublishedAdvertisements : MutableLiveData<NetworkCall<MyPublishedAdvertisementsResponse>> = MutableLiveData()
    val myPublishedAdvertisements : LiveData< NetworkCall<MyPublishedAdvertisementsResponse> > = _myPublishedAdvertisements

    // Called every time our UI is #onStarted
    fun getFreshData(){
        _myPublishedAdvertisements.value = liveData {
            emit(NetworkCall<MyPublishedAdvertisementsResponse>(NetworkStatus.LOADING, null, ""))
            val publishedAdvertisements = advertisementRepository.getMyPublishedAdvertisements()
            emit(publishedAdvertisements)
        }
    }

}

Kirill Prybylsky

03/11/2020, 11:24 AM

Does your NetworkCall extends LiveData?

Ofir Bar

03/11/2020, 11:26 AM

It is a wrapper data class to be used for all my network responses, this is the code:

Copy code

data class NetworkCall<out T>(val status: NetworkStatus, val data: T?, val message: String?) {

    companion object {
        fun <T> success(data: T?): NetworkCall<T> {
            return NetworkCall(NetworkStatus.SUCCESS, data, null)
        }

        fun <T> error(msg: String, data: T?): NetworkCall<T> {
            return NetworkCall(NetworkStatus.ERROR, data, msg)
        }

        fun <T> loading(data: T?): NetworkCall<T> {
            return NetworkCall(NetworkStatus.LOADING, data, null)
        }
    }

}

Kirill Prybylsky

03/11/2020, 11:27 AM

But you’re putting liveData{} as a value of another live data

Ofir Bar

03/11/2020, 11:29 AM

I am not sure what I am doing wrong 🤔

Kirill Prybylsky

03/11/2020, 11:32 AM

Seems like you are doing this, isn’t?

Untitled

Ofir Bar

03/11/2020, 11:35 AM

Ohhhh, ok I got what you’re saying But I still don’t understand how I use liveData{} to change the values of a MutableLiveData. Why for LiveData I can use liveData{}, and for MutableLiveData I can’t?

Kirill Prybylsky

03/11/2020, 11:40 AM

For my opinion you are trying to achieve something completely wrong. You should rethink this code. Also, there shouldn’t be any network requests from your view model class this is bad practice.

Ofir Bar

03/11/2020, 11:54 AM

I will check thanks for the help anyway @Kirill Prybylsky

12 Views