Should I make a repository as an `Object` or `Clas...

# android-architecture

[Ive Vasiljevic]

Should I make a repository as an Object or Class

[Marko Mitic]

Class if you need to inject some dependencies into repository

[ursus]

you cannot pass parameters to object

[pavi2410]

class MyRepository(private val apiService: ApiService) {

    fun getMyStuff() = apiCall { apiService.getMyStuff() }

    private fun <T> apiCall(call: suspend () -> Response<ResponseWrapper<T>>) = liveData {
        emit(Result.Loading)

        try {
            val response = call()

            if (response.isSuccessful) {
                response.body()?.let {
                    if (it.success)
                        emit(Result.Success(it.data))
                    else
                        emit(Result.Error(it.message))
                }
            }
        } catch (e: Exception) {
            emit(Result.Error())
        }
    }
}

[pavi2410]

This is how I write Repository

[Marko Mitic]

Yeah, you can't pass apiService to object, keep it a class

[gildor]

IMO Even for mid size project any object with business logic become a problem for testability and modularization
It’s usually just a matter of time when it rewritten with proper interface/class and DI

[Joan Colmenero]

@pavi2410 do you have a sample project for that one?

[pavi2410]

No, I don't. This is the code from one of my private projects.