Was wondering why `workflow-ui-android` declares m...
# squarelibraries
v
Was wondering why
workflow-ui-android
declares minSdk 21? Is it safe to override this? I'm on minSdk 16.
p
Check out the project, set the min sdk down and check for any lint warnings
v
The only blocker I could find is it's using an overload of the View constructor that takes in a theme resource id. Not sure what else could blow up at runtime, or what's in the roadmap which could affect the minSdk later on.
Trying to figure out if we (at work) should • Adopt most things as is. Fork the ui library for minSdk 16 support. (Is this something square would want as well?) • Use workflow-core and replace workflow-ui with something we implement in-house, OR • Implement the entire pattern ourselves
t
why such a low minSdk? seems the better move would be to up your project rather than lower the lib?
👎 1
2
r
cc @Zach Klippenstein (he/him) [MOD]. Needs thought. Not very excited about promising to hamstring ourselves that way. Selfishly, Square doesn’t ship anything that supports such old versions of Android, and it’s hard to imagine it happening.
It’s very interesting, though, that you found so few dependencies on fresher API calls.
p
I wouldn't go down with the min sdk. Even if you dont use anything with min-sdk < 21, having a lower min-sdk means some form of comittment to that version
r
Exactly my concern.
z
I don't remember if there was a specific reason we went with 21, other than it was the lowest one we needed to support internally and we didn't want to lock ourselves into supporting older levels.