also it seems the docs here `<https://github.com/arrow-kt/arrow/blob/main/CONTRIBUTING.md#steps>` ar...

# arrow

[thanh]

also it seems the docs here <https://github.com/arrow-kt/arrow/blob/main/CONTRIBUTING.md#steps> are outdated.

cd arrow-libs/core
./gradlew build

doesn't work any more

[simon.vergauwen]

Hey @thanh,

We also have #arrow-contributors for these kind of discussions.

Strange that the testsuite is not failing. That’s problematic 😕

[simon.vergauwen]

Yes, that markdown is indeed outdated. We’re currently in the progress of updating Dokka, and replacing Ank with Knit etc.

[simon.vergauwen]

However IIRC the buildDoc or runSite command should still work. Is this failing?

[thanh]

Hey @simon.vergauwen I realized that right after I posted here 😅
I think buildDoc or runSite works but in root directory not in arrow-libs directory anymore.
I faced this error when trying to add a filter function to Optional in optics (as we discussed few weeks ago).

[thanh]

I created a pr for it https://github.com/arrow-kt/arrow/pull/2588. It is in draft, because I need to find out how to write tests for it, and it needs some more documentation (I probably just copy docs from Monocle 😄 )

[stojan]

is Ank getting deprecated in favor of Knit? 🤔

[simon.vergauwen]

@stojan yes. We’ve already replaced all the ank usage in Arrow with Knit

[simon.vergauwen]

@thanh you can add test specific for filter here, https://github.com/arrow-kt/arrow/blob/main/arrow-libs/optics/arrow-optics/src/commonTest/kotlin/arrow/optics/OptionalTest.kt

If it passes the law, we should still test for specific behavior since the laws just check if it adheres to the generic behaviors of Optional.

[simon.vergauwen]

Yes, it doesn’t work from the folder anymore since we’ve flattened the project for simpler maintenance.

[thanh]

I just added a test Optional.listHead to make sure set function work correctly: https://github.com/arrow-kt/arrow/pull/2589

[thanh]

Hey @simon.vergauwen, when you have time can you please review my two PRs above. I'll update the first PR with some more document. But I don't not sure how to add test laws for it. It seems in the laws, we try to compose the function with another function and make sure the result satisfies all the laws?

[simon.vergauwen]

I’ll try to make some time this week to properly look into it 👍

[simon.vergauwen]

Thanks for the awesome work @thanh 🙌

[thanh]

yeah, no rush!