Looks like its an open issue to update this: <http...
# arrow
r
Looks like its an open issue to update this: https://github.com/arrow-kt/arrow-integrations/issues/44
r
Hi @rpillay, we had discussed this internally before 0.12 and 0.13 and decided that we are no longer interested in maintaining specific integrations like this one since really none of us use Jackson and there are way too many other libs out there to support in the same way. If you or anyone reading this is interested in maintaining this module we can reenable the repository and we’ll be happy to facilitate access to review and help others also interested in these integrations.
I’ll update the issue to reflect whatever comes out of this or close for good if there is no interest. Thanks!
r
👍 Makes sense. Would be good to update the readme on that repo so that people who arrive there know its now dead
m
@raulraja we have basically a copy (more like a similarly implemented one) of this with some bugfixes maintained in our codebase, thinking to contribute it here if that suits
👍 2
I didn't even know this existed before recently
r
@mitch makes sense and if you are interested on maintaining it we can give you admin rights on that repo.
m
👍
r
I unarchived it and it’s ready for PRs if anyone is interested, may require coordination to publish later once is ready for release. thanks!
m
Awesome you're a champ @raulraja!
I'll raise a pr as soon as possible
r
thanks @mitch 🙏
m
@raulraja @Rachel PR’s up https://github.com/arrow-kt/arrow-integrations/pull/52 i aimed for 0.11.0 support first.
❤️ 2
@Rachel @raulraja thanks for the reviews! i’ve addressed the comments. what’s the accepted process in arrow generally? do I wait until one of the admins merge the PR or would the PR requester is expected to be doing that.
r
@mitch Normally all PRs in arrow requires two approvals with someone with write access. We gave you write access to the integrations repo so you can merge yourself if you want or someone will eventually do it as we review outstanding open PRs of the week 🙂
👍 1
m
Awesome!! Thanks Raul. I'll do that a bit later today
👍 1
r
It's already merged @mitch We're working on the configuration now to be able to publish these libraries again 🙌 I'll let you know when it's ready!
m
That's awesome!! Thanks @Rachel
r
@mitch, sorry for the delay, the missing library is already published: https://repo1.maven.org/maven2/io/arrow-kt/arrow-integrations-jackson-module/
message has been deleted
I also pushed
support-0.12.0
branch in
arrow-integrations
repository I think everything is working for Arrow 0.12.0 in that branch Please, take a look at it and if it's ok for you, we'll publish
0.12.0
on Monday for both libraries in this case: • arrow-integrations-jackson-module • arrow-integrations-retrofit-adapter Thank you again for your contribution and have a wonderful weekend!! 🌲
🎉 1
m
I will! Thanks again @Rachel and @raulraja
This is really cool, i’ve checked that branch and definitely confirmed everything to work nicely with
0.12.0
!
👏 2
I’ve also raised a pr to update the readme @Rachel
🙌 1
r
Thanks @mitch!!
0.12.0
is already published. Please, to keep the compatibility with all the Arrow libraries, it would be necessary to publish
0.12.1
as well (transitive dependencies will use
0.12.1
)
0.12.1
includes these fixes: https://github.com/arrow-kt/arrow/releases/tag/0.12.1 I'll wait your confirmation 🙌 The pull request is ready to publish
0.12.1
, https://github.com/arrow-kt/arrow-integrations/pull/60 Thank you so much!!
Awesome, thanks @mitch!!
0.12.1
is already published. We already created
support-0.13.0
branch for Arrow
0.13.0
In this case: •
arrow-integrations-jackson-module
continues working
arrow-integrations-retrofit-adapter
needs rework ⚠️ If you're interested in
arrow-integrations-jackson-module
, the other library could be disabled until we have support for it.
m
Thanks @Rachel. Sounds good. What's the direction of retrofit integration given that we've deprecated higher kinds and IO?
Cc @raulraja
r
I think if retrofit already supports
suspend
then that integration is no longer needed
Those integrations are constrained to Async which is now gone as well as IO. Is there anything in there we can’t do with suspend?
I recall we discussed these a while back and I think that was the conclusion since Retrofit has now support to declare suspend functions without
Call
👍 1
r
Great! So we'll disable ``arrow-integrations-retrofit-adapter` to continue with the releases of
arrow-integrations-jackson-module
Thanks!! 🙌
🙌 1
m
brilliant!