<@U7D34M1DX> not sure about windows but if it's co...
# arrow
r
@Mike not sure about windows but if it's code related you can just use
test
locally and when you send the PR it will try the full build on travis and run detekt
m
Thanks. I'll try that. And I'll have the Detekt plugin installed in IntelliJ so it will warn me. First time trying this level of dev on Windows. Use Mac at work, but will try this project on it to see if it's truly Windows related.
It's definitely a windows incompatibility thing for detekt. I notice the project is directly executing detekt as a javaexec task. Unfortunately this doesn't work cross- platform without some work as windows requires different parameters than Unix. I noticed the project is using a really old version of detekt and I assume a gradle plugin wasn't available. If you'd like, I can upgrade the detekt version and applying the gradle plugin. Detekt a has improved a lot so depending on how many things it flags, this could be very easy or very hard. Unfortunately the tests don't pass on Windows either. Haven't dug into that yet, but will. Or I'll dig into WSL, although my initial attempt wasn't very successful. WSL =Windows subsystem for Linux just in case you weren't familiar with it and would just be me locally.
At least I figured out why gradlew wouldn't run in WSL. I suspect my Git options aren't set correctly, so the gradlew had CRLF rather than LF. I'll double check everything before I create any PR's.
r
If you want to attempt to upgrade detekt we'd definitely love that contribution. Not sure if someone has tried before or there are any known issues
m
I suspect due to extra strictness in newer versions, it may require a lot of changes. I'll take a stab at it, and if nothing else, give you an idea of how large a task it is.
r
Thanks!