Why was this change introduced? <https://github.co...
# react
@Leonid Khachaturov
I can't use kotlin-react from my UMD module
t
Do you need
umd
for Kotlin or for Webpack?
It works fine in scheme: Kotlin -
commonjs
Webpack - any format
r
It's for KVision module and whole KVision is UMD.
I don't even know if I could configure a single submodule for commonjs.
But it would still be not compatible with existing apps which use umd.
There is no comment and no issue linked with this commit. It would be nice to know the rationale behind this change.
t
For now -
commonjs
for libraries (for apps too) single valid variant, which I see.
@JsNonModule
doesn’t work in common case (example). Additional point - future ES6 modules, which also modular.
It would be nice to know the rationale behind this change.
@Robert Jaros We will add it README
🙏 1
s
@Robert Jaros after internal discussion, we’ve reverted this change and will publish with UMD starting again in the next version. https://github.com/JetBrains/kotlin-wrappers/commit/92b3c1b7d5499eac9a85158c0657a8872b3b96ad. Apologies for the hassle.
👍 3