Hi, what is the equivalent of `hiltViewModel()` i...

# koin

[Ruben Quadros]

Hi, what is the equivalent of hiltViewModel() in koin?
I want to get parameters passed to compose navigation using SavedStateHandle in my viewmodel.

[xxfast]

there’s koin-view-model, where you can do

viewModel { param -> 
  ViewModel(handle = param.get<SavedStateHandle>()) 
}

[arnaud.giuliani]

still problem with DSL?

[arnaud.giuliani]

what version?

[Ruben Quadros]

I have a compose destination

composable(
            route = "$Login/{$IS_BACK_ALLOWED}",
            arguments = listOf(
                navArgument(IS_BACK_ALLOWED) { type = NavType.BoolType }
            )
        ) {
            LoginScreen()
        }

My screen

LoginScreen(
   loginViewModel: LoginViewModel = getViewModel()
)

My Viewmodel

class LoginViewModel(handle: SavedStateHandle): ViewModel() {
    
       fun doSomething() {
          val isBackAllowed = handle.get<Boolean>(IS_BACK_ALLOWED)
       }
}

But isBackAllowed is always null

koin version 3.1.4

[Ruben Quadros]

Am I doing something wrong? Or is it not supported in koin ?

[arnaud.giuliani]

can you extract a sample project?

[Ruben Quadros]

Sure will do and ping back

[Ruben Quadros]

Please check this sample project
https://github.com/rubenquadros/Koin-Compose-Sample

[arnaud.giuliani]

ok thanks 👍

[Ruben Quadros]

Hi Arnaud, did you get a chance to go through the sample?

[arnaud.giuliani]

not yet

[Ruben Quadros]

I am passing nav args in multiple destinations and right now I have to pass them from composable to viewmodel which is a pain 🥲. It would be great if you can have a look at the sample and provide your guidance. Thanks in advance! 🙂

[arnaud.giuliani]

yeah, extracting everything to prepare Compose projects and next Koin versions those days

[arnaud.giuliani]

give me more time to take a look

[arnaud.giuliani]

did you tried navigation graph ViewModel?

[arnaud.giuliani]

I ve seen your app code. It’s a limitation of Koin for now. Need to fix it

[Ruben Quadros]

Thanks a lot for the reply! If you are accepting contributions would love to go through the code and submit my contribution for the same 🙂

[arnaud.giuliani]

koin-androidx-compose is in a sperated github project to help go over compose project

[arnaud.giuliani]

but have its in own sync rythm

[arnaud.giuliani]

from what I’ve seen, the “official” ktx viewModel() function is running against NavBackStackEntry

[arnaud.giuliani]

and then, internal SavedStateFactory is having default arguments from NavBackStackEntry

[arnaud.giuliani]

this is where, it’s missing something on Koin side

[arnaud.giuliani]

I would consider rewrite from scratch if needed, but we need to wire on Koin context to resolve things

[arnaud.giuliani]

feel free to come chat in #koin-dev

[Ruben Quadros]

With my limited understanding I have made some changes and got it to work. But I am not sure how correct my changes are 🙈. I have pushed the changes in the same sample. Would be great if you can check below commit whenever you get some time. Eagerly waiting for your reply 🙂

https://github.com/rubenquadros/Koin-Compose-Sample/commit/b814bd1c99eed8c84c1c0c1a1b1e7f4fba73c9f2

[arnaud.giuliani]

interesting, let me check 🙂

[arnaud.giuliani]

also just a warning, as Compose is runiing against kotlin 1.5 and you pull version 1.6 from other dependencies

[arnaud.giuliani]

does it do the job your patch? seems a good quick patch for now 👍

[Ruben Quadros]

yes it is doing the job.. will raise a pr and you can check again 🙂

[arnaud.giuliani]

great job 👍

[Ruben Quadros]

Please review the PR. Please let me know if any changes need to be done in the documentation as well 🙂

https://github.com/InsertKoinIO/koin/pull/1286

[arnaud.giuliani]

Let me check that yes 🙂