in 3.1.0 this definition is deprecated. Could you describe how this `parameters.get()` intent to be...

# koin

[aipok]

in 3.1.0 this definition is deprecated. Could you describe how this parameters.get() intent to be used?

[arnaud.giuliani]

yep, you have the description in the warning

[arnaud.giuliani]

because now you can write viewModel<UserCreatedPopupViewModel>() and it will handle your parameters

[arnaud.giuliani]

or replace viewModel { params -> UserCreatedPopupViewModel(params.get()) }

[aipok]

yes it is working but not always . Previously it was clearly visible in declaration what are the expected parameters. Now it is hidden behind the caller. Also nullable parameters aren’t available anymore?
Here is the example that gives me an error:
I have following inside my fragment and arguments in this case is nullable Bundle

private val viewModel: FlashNotificationViewModel by inject {
    parametersOf(arguments)
}

This causes the issue like this… in my module I have to add class type and I assume it will fail in case the bundle will be null from the caller…

viewModel { params ->
        val bundle = params.get<Bundle>()
        FlashNotificationViewModel(
            bundle.getParcelable("notification"),
            bundle.getString("form_validation_token") ?: Consts.empty,
            get()
        )
    }

[aipok]

also without class it will show an error

[aipok]

ok, I can see that I could use getOrNull for parameters that could be nullable

[aipok]

yes I can use getOrNull but only with following syntax

val bundle = params.getOrNull<Bundle>(Bundle::class)

below is not possible

val bundle = params.getOrNull<Bundle>()

and

val bundle = params.getOrNull(Bundle::class)

[aipok]

I can use like this val bundle: Bundle? = params.getOrNull(Bundle::class) which is a bit better 🤔

[arnaud.giuliani]

the problem is that destructured declaration is based on generated accessor like on data class

[arnaud.giuliani]

and those are not compile safe

[arnaud.giuliani]

I’m quite suprised that you can passed nullable Type 🤔

[arnaud.giuliani]

ok, need getOrNull inferred type version

[aipok]

Yap, what would be good.