Hi, I have just noticed that koin strips quotes ou...

# koin

[nikolaymetchev]

Hi, I have just noticed that koin strips quotes out of environment variables.

fun saveProperties(properties: Properties) {
        if (_koin.logger.isAt(Level.DEBUG)) {
            _koin.logger.debug("load ${properties.size} properties")
        }

        val propertiesMapValues = properties.toMap() as Map<String, String>
        propertiesMapValues.forEach { (k: String, v: String) ->
            saveProperty(k, v.quoted())
        }
    }

v.quoted() is the culprit
This makes it very hard to put JSON in environment variables and get it back such that parsers don’t complain! Why are quotes being stripped?

[arnaud.giuliani]

perhaps a bug with properties 🤔

[arnaud.giuliani]

what version do you use?

[nikolaymetchev]

2.2.2

[nikolaymetchev]

Looks like master doesn’t have that problem: https://github.com/InsertKoinIO/koin/blob/master/core/koin-core/src/commonMain/kotlin/org/koin/core/registry/PropertyRegistry.kt

[arnaud.giuliani]

yes, master will be backported to 2.2.x as 2.3.0

[nikolaymetchev]

Thanks @arnaud.giuliani Do you have an ETA on that release?

[arnaud.giuliani]

I would say Q2

[arnaud.giuliani]

End of April I will migrate all main 2.x versions to maven central

[arnaud.giuliani]

from there I will be able to backport all 3.x patches

[nikolaymetchev]

Will there be a 3.x release (non beta/alpha) before that?

[arnaud.giuliani]

yes

[arnaud.giuliani]

3.0.1 is almost stable

[nikolaymetchev]

Thank you

[Dan]

Hi @nikolaymetchev 🙂

[nikolaymetchev]

Hi @Dan - Do I know you?

[nikolaymetchev]

@arnaud.giuliani This problem still exists in koin 3.0.1 https://github.com/InsertKoinIO/koin/blob/392682bc6ebe428952485a45eb13af06a79789eb[…]rc/jvmMain/kotlin/org/koin/core/registry/PropertyRegistryExt.kt

[arnaud.giuliani]

arf, too bad 😕

[nikolaymetchev]

Is that likely to be fixed, or is there a reason for it?

[arnaud.giuliani]

a regression, or something ? 🤔 or perhaps fixed on 2.2.2 ?

[arnaud.giuliani]

else we just need to reapply it on 3.0.1 for next patch 3.0.2

[nikolaymetchev]

2.2.2 has the same problem: https://github.com/InsertKoinIO/koin/blob/4f278bd9b1fa4667910bcd8e313ddef574383d1e[…]core/src/main/kotlin/org/koin/core/registry/PropertyRegistry.kt

[nikolaymetchev]

It looks like it has been there since inception.

[nikolaymetchev]

@arnaud.giuliani Not sure why the quoted method changed here. I thought I made it obvious that it should be removed altogether. With the change highlighted you now get and array out of bounds exception on an empty string.

[arnaud.giuliani]

yep, seen that 🙄

[nikolaymetchev]

Why do you have this method? Just delete it. Properties shouldn’t be amended…

[arnaud.giuliani]

no because in some cases, properties import add ’ char

[arnaud.giuliani]

like system import

[nikolaymetchev]

This functionality should be optional. I am trying to store some JSON in a property and this completely breaks it.

[arnaud.giuliani]

ok I see