Hi <@U2JKKPMEE>, my I ask a question. I found thi...

# koin

[Archie]

Hi @arnaud.giuliani, my I ask a question.

I found this in the documentation:

class Presenter(val view : MyViewContract)

val androidModule = module {

    scope<MyActivity> {
        // inject current MyActivity
        scoped { Presenter(get()) }
    }
}

since the activityScope() is backed inside the ViewModel :

// Create Activity scope (backed by ViewModel)
override val scope: Scope by lazy { activityScope() }

And the presenter have the reference of the View wouldn't this leak the Activity? If I understand it correctly, since the scope is backed inside a ViewModel the same instance of Presenter will be provided when the Activity did some configuration changes (such as device rotation)... The Activity will be destroyed with its views and a new Activity will be created but.. the presenter is still holding the instance of the destroyed view (View of the Old Activity)...

I am really confuse.

[arnaud.giuliani]

yes, this is a current limitation. Best for Presenter is to override current scope with newScope()

[arnaud.giuliani]

2.2.1 with activityScope() don’t keep source anymore

[arnaud.giuliani]

viewModel holder is closing on end of activity

[arnaud.giuliani]

Hilt introduced activityScope and activityRetrainedScope

[Archie]

I see then, there will also be a activityRetrainedScope in koin as well?

[arnaud.giuliani]

yes, I think it can be interesting to clearly make the distinguish

[Archie]

Awesome! May I ask another question? Shouldn't Scoped Dependencies defined in ScopedActivity also be available inside ScopedFragment?

[arnaud.giuliani]

yes we could do

[Archie]

Alright thank you very much!