Anyone used `getViewModel()` in a composable, whe...

# koin

[nrobi]

Anyone used getViewModel() in a composable, where the parameters of the vm are subject to change?

[nrobi]

https://github.com/InsertKoinIO/koin/issues/924

[arnaud.giuliani]

you mean, your ViewModel instance is always the same?

[nrobi]

yes

[arnaud.giuliani]

I believe your ViewModel instance won’t change, you’ll request always the same instance

[arnaud.giuliani]

to confirm

[arnaud.giuliani]

injection params are used for instance creation

[arnaud.giuliani]

then it’s used 1st time

[nrobi]

yupp, these issues can be solved by modifying the state of the current ViewModel instance.
However I think it may go against the whole recomposition pattern.

Not sure though how compose handles this under the hood and if it can be implemented in koin. Is there a possibility to consider checking the parameters, before retrieving the instance?

[arnaud.giuliani]

consider checking the parameters, before retrieving the instance

wdyt?

[nrobi]

I mean I’m not sure why the same instance is retrieved. Just to make sure I’ve understood you, within the same scope if you try to get an instance of a VM twice with different parameters, the second call will get you the already created instance (with the first parameter). Right?

[nrobi]

Basically I meant if there is a way of checking the parameters (given with parametersOf) and if different regardless of scope return a new instance. Or is this something that’s solved by the ViewModelProvider and is OoS for Koin?

[nrobi]

@arnaud.giuliani I’ve did a bit of digging:

We should create a public API that allows developers to conveniently scope ViewModel to composition lifecycle.

https://issuetracker.google.com/issues/165642391

[arnaud.giuliani]

interesting 👍